Page MenuHomePhabricator
Differential D6124

[native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE`
ClosedPublic
Actions

Authored by atul on Dec 30 2022, 4:52 PM.
Tags
None
Referenced Files
F3392096: D6124.id20469.diff
Sat, Nov 30, 6:57 AM
F3392095: D6124.diff
Sat, Nov 30, 6:57 AM
Unknown Object (File)
Mon, Nov 11, 6:40 PM
Unknown Object (File)
Mon, Nov 4, 1:21 AM
Unknown Object (File)
Mon, Nov 4, 1:21 AM
Unknown Object (File)
Oct 26 2024, 10:55 PM
Unknown Object (File)
Oct 26 2024, 10:55 PM
Unknown Object (File)
Oct 26 2024, 10:55 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM1220a5821da4: [native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE`
Summary

Make necessary JSI calls to get primaryIdentityPublicKey and set siwe-primary-identity-public-key header before loading landing/SIWE webview.

Depends on D6115

Test Plan

Logged primaryIdentityPublicKey value and ensured it was as expected.

In subsequent diff will capture the value from header and pass to landing/SIWE component so it can be included in the signed SIWEMessage.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 30 2022, 4:52 PM
atul published this revision for review.Dec 30 2022, 4:53 PM
Harbormaster completed remote builds in B14993: Diff 20462.Dec 30 2022, 5:06 PM
atul edited the summary of this revision. (Show Details)Dec 30 2022, 6:02 PM
atul added a parent revision: D6115: [native] Modify `getUserPublicKey()` JSI function to return `ClientPublicKeys`.
atul added a child revision: D6125: [lib] Introduce `isValidPrimaryIdentityPublicKey`.Dec 30 2022, 6:03 PM
ashoat accepted this revision.Dec 30 2022, 8:53 PM
ashoat added inline comments.
native/account/siwe-panel.react.js
91

The string 'anonymous' passed here doesn't actually get used for anything, does it?

This revision is now accepted and ready to land.Dec 30 2022, 8:53 PM
atul added inline comments.Dec 30 2022, 9:14 PM
native/account/siwe-panel.react.js
91

Nah, and based on discussion on Linear + further investigation it looks like the argument can be removed altogether. I'll replace "anonymous" with "PLACEHOLDER" until I get to https://linear.app/comm/issue/ENG-2601/remove-userid-arg-from-jsi-initializecryptoaccount to make it a bit more clear.

atul updated this revision to Diff 20469.Dec 30 2022, 9:16 PM

anonymous -> PLACEHOLDER

This revision was landed with ongoing or failed builds.Dec 30 2022, 9:20 PM
Closed by commit rCOMM1220a5821da4: [native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1220a5821da4: [native] Generate `primaryIdentityPublicKey` and pass to `landing/SIWE`.
Harbormaster completed remote builds in B14996: Diff 20469.Dec 30 2022, 9:30 PM

Revision Contents
Changeset List

PathSize
native/
account/
13 lines

Diff 20462

View Options

native/account/siwe-panel.react.js

Loading...