Paths

Table of Contentst

Differential D6129

[lib] Introduce `getSIWEStatementForPublicKey(...)`
ClosedPublic
Actions

Authored by atul on Dec 31 2022, 10:37 AM.

Tags

None

Referenced Files

	F315621: 0b38f4.png
	Jan 3 2023, 9:34 PM

Subscribers

None

Details

Reviewers

ashoat
tomek

Commits

rCOMM3142750b0b85: [lib] Introduce `getSIWEStatementForPublicKey(...)`

Summary

Given a public key, getSIWEStatementForPublicKey(...) generates a statement for SIWE message that conforms to what is described in the whitepaper:

https://blob.sh/a3d138.png

Depends on D6128

Test Plan

included a unit test

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 31 2022, 10:37 AM

atul published this revision for review.Dec 31 2022, 10:38 AM

Harbormaster completed remote builds in B15001: Diff 20478.Dec 31 2022, 10:51 AM

atul edited the summary of this revision. (Show Details)Dec 31 2022, 10:54 AM

atul added a parent revision: D6128: [landing] Add `siwePrimaryIdentityPublicKey` to `SIWEContext`.

atul added a child revision: D6130: [lib] Introduce `isValidSIWEStatementWithPublicKey(...)`.Dec 31 2022, 10:54 AM

ashoat accepted this revision.Jan 2 2023, 3:21 AM

ashoat added inline comments.

lib/utils/siwe-utils.js
48 ↗	(On Diff #20478)	Can we add a newline here?

This revision is now accepted and ready to land.Jan 2 2023, 3:21 AM

ashoat added inline comments.Jan 2 2023, 3:55 AM

lib/utils/siwe-utils.js
49 ↗	(On Diff #20478)	Should we just use `siweStatement` here to avoid copy-paste?

atul added inline comments.Jan 3 2023, 9:34 PM

lib/utils/siwe-utils.js
48 ↗	(On Diff #20478)	No, newline characters are prohibited in the `statement` field of the SIWE Message:
49 ↗	(On Diff #20478)	I'll make that change before landing. I initially decided against that to avoid too much redirection, but not a big deal.

rebase before addressing feedback

atul attached a referenced file: F315621: 0b38f4.png. (Show Details)Jan 3 2023, 9:35 PM

rebase after addressing feedback and before landing

This revision was landed with ongoing or failed builds.Jan 3 2023, 9:41 PM

Closed by commit rCOMM3142750b0b85: [lib] Introduce `getSIWEStatementForPublicKey(...)`. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3142750b0b85: [lib] Introduce `getSIWEStatementForPublicKey(...)`.

Harbormaster completed remote builds in B15053: Diff 20535.Jan 3 2023, 9:49 PM

Harbormaster completed remote builds in B15054: Diff 20536.Jan 3 2023, 9:53 PM

Revision Contents
Changeset List

Path

Size

lib/

utils/

11 lines

siwe-utils.test.js

11 lines

Diff 20537

lib/utils/siwe-utils.js

Loading...

lib/utils/siwe-utils.test.js

Loading...