Page MenuHomePhabricator

[keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table
ClosedPublic

Authored by atul on Dec 31 2022, 5:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 6:26 PM
Unknown Object (File)
Tue, Jun 11, 12:51 PM
Unknown Object (File)
Thu, Jun 6, 8:22 PM
Unknown Object (File)
Fri, May 24, 8:32 AM
Unknown Object (File)
Fri, May 24, 7:21 AM
Unknown Object (File)
Fri, May 24, 7:21 AM
Unknown Object (File)
Fri, May 24, 7:21 AM
Unknown Object (File)
Fri, May 24, 7:21 AM
Subscribers
None

Details

Summary

Stringify the SIWESocialProof object and store in the social_proof column of the cookies table.


Depends on D6135

Test Plan

public_key and social_proof columns populated as expected:

9d89c3.png (724×3 px, 295 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 31 2022, 5:45 AM
Harbormaster failed remote builds in B15011: Diff 20488!
atul edited the test plan for this revision. (Show Details)
atul retitled this revision from [DRAFT] Store `SIWESocialProof` in `social_proof` column of `cookies` table to [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table.
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 31 2022, 4:22 PM
Harbormaster failed remote builds in B15014: Diff 20491!
atul edited the test plan for this revision. (Show Details)

flow

atul requested review of this revision.Dec 31 2022, 4:35 PM

Please address before landing

lib/types/siwe-types.js
30–31 ↗(On Diff #20492)

Can these be read-only?

This revision is now accepted and ready to land.Jan 1 2023, 8:02 PM
lib/types/siwe-types.js
30–31 ↗(On Diff #20492)

Yeah totally

This revision was landed with ongoing or failed builds.Jan 4 2023, 11:29 PM
This revision was automatically updated to reflect the committed changes.