Paths

Table of Contentst

[keyserver] Pull `primaryIdentityPublicKey` out of SIWE statement and pass to `siweAccountCreationRequest`
ClosedPublic
Actions

Authored by atul on Dec 31 2022, 4:04 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMda1f612382ab: [keyserver] Pull `primaryIdentityPublicKey` out of SIWE statement and pass to…

Summary

Use the utility functions introduced earlier in the stack to pull primaryIdentityPublicKey out of the signed SIWE message statement (if it exists).

For native clients we expect the value of primaryIdentityPublicKey to be a string that conforms to primaryIdentityPublicKeyRegex and for web clients we expect null.

Depends on D6132

Test Plan

public key appears in signing request:

public key properly extracted on keyserver:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 31 2022, 4:04 AM

atul edited the test plan for this revision. (Show Details)Dec 31 2022, 4:05 AM

atul published this revision for review.Dec 31 2022, 4:07 AM

Harbormaster failed remote builds in B15006: Diff 20483!Dec 31 2022, 4:07 AM

atul added a child revision: D6134: [keyserver] Store `primaryIdentityPublicKey` in `public_key` column of `cookies` table.Dec 31 2022, 4:26 AM

resolve flow issue

Harbormaster completed remote builds in B15008: Diff 20485.Dec 31 2022, 4:44 AM

ashoat accepted this revision.Jan 1 2023, 8:02 PM

This revision is now accepted and ready to land.Jan 1 2023, 8:02 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jan 3 2023, 2:49 PM

Closed by commit rCOMMda1f612382ab: [keyserver] Pull `primaryIdentityPublicKey` out of SIWE statement and pass to… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMda1f612382ab: [keyserver] Pull `primaryIdentityPublicKey` out of SIWE statement and pass to….

Harbormaster completed remote builds in B15062: Diff 20549.Jan 3 2023, 2:52 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

account-creator.js

1 line

responders/

user-responders.js

20 lines

Diff 20551

View Options

keyserver/src/creators/account-creator.js