[lib] Introduce `isValidSIWEStatementWithPublicKey(...)`
ClosedPublic
Actions

Authored by atul on Dec 31 2022, 2:54 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM7e3a7434220c: [lib] Introduce `isValidSIWEStatementWithPublicKey(...)`

Summary

Introduce isValidSIWEStatementWithPublicKey(...) to check if SIWE statement is valid statement that includes the Device IdPubKey as described in the whitepaper: https://blob.sh/a3d138.png

Depends on D6129

Test Plan

included a unit test (will include more later)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 31 2022, 2:54 AM

atul published this revision for review.Dec 31 2022, 2:57 AM

atul added inline comments.

lib/utils/siwe-utils.js
53 ↗	(On Diff #20479)	Yes, this is a long line that exceeds the 80 character width limit. Saw that there are ways to split a regex across multiple lines on StackOverflow (https://stackoverflow.com/questions/12317049/how-to-split-a-long-regular-expression-into-multiple-lines-in-javascript), but the solutions didn't seem as clean and there were some "gotchas." Open to any suggestions.

Harbormaster completed remote builds in B15002: Diff 20479.Dec 31 2022, 3:08 AM

atul edited the summary of this revision. (Show Details)Dec 31 2022, 3:12 AM

atul added a child revision: D6131: [lib] Introduce `getPublicKeyFromSIWEStatement(...)`.Dec 31 2022, 3:14 AM

ashoat accepted this revision.Jan 1 2023, 7:22 PM

ashoat added inline comments.

lib/utils/siwe-utils.js
53 ↗	(On Diff #20479)	Eh whatever. We do this in other places with JS RegExp literals in the codebase, like lib/shared/markdown.js Can you update this to have a newline?