Page MenuHomePhabricator
Differential D6136

[keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table
ClosedPublic
Actions

Authored by atul on Dec 31 2022, 5:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 3:57 AM
Unknown Object (File)
Fri, Jun 21, 3:57 AM
Unknown Object (File)
Fri, Jun 21, 3:57 AM
Unknown Object (File)
Fri, Jun 21, 3:57 AM
Unknown Object (File)
Fri, Jun 21, 3:56 AM
Unknown Object (File)
Fri, Jun 21, 1:31 AM
Unknown Object (File)
Fri, Jun 21, 1:31 AM
Unknown Object (File)
Wed, Jun 19, 8:43 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMc13c35676480: [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table
Summary

Stringify the SIWESocialProof object and store in the social_proof column of the cookies table.

Depends on D6135

Test Plan

public_key and social_proof columns populated as expected:

9d89c3.png (724×3 px, 295 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 31 2022, 5:41 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 31 2022, 5:45 AM
Harbormaster failed remote builds in B15011: Diff 20488!
atul updated this revision to Diff 20491.Dec 31 2022, 4:18 PM

fix

atul edited the summary of this revision. (Show Details)Dec 31 2022, 4:19 PM
atul edited the test plan for this revision. (Show Details)
atul retitled this revision from [DRAFT] Store `SIWESocialProof` in `social_proof` column of `cookies` table to [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table.
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 31 2022, 4:22 PM
Harbormaster failed remote builds in B15014: Diff 20491!
atul updated this revision to Diff 20492.Dec 31 2022, 4:22 PM
atul edited the test plan for this revision. (Show Details)

flow

Harbormaster completed remote builds in B15015: Diff 20492.Dec 31 2022, 4:35 PM
atul requested review of this revision.Dec 31 2022, 4:35 PM
ashoat accepted this revision.Jan 1 2023, 8:02 PM

Please address before landing

lib/types/siwe-types.js
30–31

Can these be read-only?

This revision is now accepted and ready to land.Jan 1 2023, 8:02 PM
atul added inline comments.Jan 3 2023, 3:38 PM
lib/types/siwe-types.js
30–31

Yeah totally

atul updated this revision to Diff 20558.Jan 3 2023, 3:57 PM

rebase

atul updated this revision to Diff 20559.Jan 3 2023, 3:59 PM

address feedback

Harbormaster completed remote builds in B15067: Diff 20558.Jan 3 2023, 4:11 PM
Harbormaster completed remote builds in B15068: Diff 20559.
atul updated this revision to Diff 20590.Jan 4 2023, 11:25 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jan 4 2023, 11:29 PM
Closed by commit rCOMMc13c35676480: [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc13c35676480: [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table.
Harbormaster completed remote builds in B15097: Diff 20590.Jan 4 2023, 11:40 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
3 lines
responders/
21 lines
session/
12 lines
lib/
types/
6 lines

Diff 20492

View Options

keyserver/src/creators/account-creator.js

Loading...
View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

keyserver/src/session/cookies.js

Loading...
View Options

lib/types/siwe-types.js

Loading...