[keyserver] Make opaque-ke-napi build on Windows
ClosedPublic
Actions

Authored by michal on Jan 3 2023, 5:36 AM.

Details

Reviewers

varun
atul
tomek
ashoat

Commits

rCOMM821cd1916522: [keyserver] Make opaque-ke-napi build on Windows

Summary

We want to be able to build the desktop app on Windows but currently opaque-ke-napi fails.
As far as I've investigated the issue happens because when you run napi build it searches for node_modules/@napi-rs/cli/index.js. It can't find it on windows because of some symlink weirdness
(we are using yarn workspaces so we are running this in node_modules/native folder that's symlinked to the real folder).

This diff uses the nohoist option to keep @napi-rs/cli inside native/node-modules (otherwise it's hoisted to the root node_modules). The biggest problem with this approach is that if we ever use @napi-rs/cli in some other package it wouldn't be shared.

Test Plan

yarn cleaninstall on macOS laptop works
CI on phab works
yarn cleaninstall on Windows laptop and on GitHub Windows Runner (in a forked repo) works

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Jan 3 2023, 5:36 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 3 2023, 5:36 AM

Alternatively, we could do something similar to D6142 (make a bash script and skip napi build step if it's Windows).

keyserver/addons/opaque-ke-napi/package.json
7	We need to make this package private to use the `workspaces` option.

Harbormaster completed remote builds in B15038: Diff 20516.Jan 3 2023, 5:50 AM

michal requested review of this revision.Jan 3 2023, 5:50 AM

Doesn't seem great but I'm not sure of a better option. The nohoist shouldn't have any additional performance cost since this is the only place we use it

This revision is now accepted and ready to land.Jan 3 2023, 10:43 AM

michal added a child revision: D6146: [CI] Build macOS and Windows desktop app on github.Jan 4 2023, 4:45 AM

Closed by commit rCOMM821cd1916522: [keyserver] Make opaque-ke-napi build on Windows (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 5 2023, 7:15 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM821cd1916522: [keyserver] Make opaque-ke-napi build on Windows.