[CI] Build macOS and Windows desktop app on github
ClosedPublic
Actions

Authored by michal on Jan 3 2023, 7:23 AM.

Details

Reviewers

atul
tomek
• jon

Commits

rCOMM71504e664e68: [CI] Build macOS and Windows desktop app on github

Summary

ENG-2532
Adds GitHub workflows for building the desktop app on Windows and macOS. The Windows one should be especially useful because nobody develops on a Windows machine so if it breaks we wouldn't catch it until later.
They are heavily inspired by the Android/ iOS workflows.

Test Plan

Tested on a fork but without secrets for now.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jan 3 2023, 7:23 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 3 2023, 7:23 AM

michal added inline comments.Jan 3 2023, 7:25 AM

.github/workflows/macos_ci.yml
24–44 ↗	(On Diff #20519)	Taken from the iOS workflow
.github/workflows/windows_ci.yml
29–35 ↗	(On Diff #20519)	The general idea was taken from the Android workflow but I'm using a Windows utility `certutil` for decoding base64.

Harbormaster completed remote builds in B15041: Diff 20519.Jan 3 2023, 7:37 AM

michal requested review of this revision.Jan 3 2023, 7:37 AM

ashoat added a reviewer: • jon.Jan 3 2023, 10:44 AM

Looks good, let's remove the pull_request trigger though

.github/workflows/macos_ci.yml
12–13 ↗	(On Diff #20519)	We actually don't want these to run on pull request. Secrets aren't available by default for PRs because it's possible for someone malicious to modify workflow and put up a PR that eg writes secrets to a file and then uploads them or something along those lines. I'll put up a diff right now to cut them from the other workflows