Paths

Table of Contentst

Differential D6150

[GH Actions] Remove `pull_request` trigger for Android/iOS workflows
ClosedPublic
Actions

Authored by atul on Jan 3 2023, 10:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 21, 12:44 AM

	Unknown Object (File)
	Sun, Apr 21, 12:44 AM

	Unknown Object (File)
	Sun, Apr 21, 12:44 AM

	Unknown Object (File)
	Sun, Apr 21, 12:44 AM

	Unknown Object (File)
	Sun, Apr 21, 12:40 AM

	Unknown Object (File)
	Apr 2 2024, 11:01 AM

	Unknown Object (File)
	Apr 2 2024, 12:37 AM

	Unknown Object (File)
	Apr 2 2024, 12:37 AM

View All 76 Files

Subscribers

Details

Reviewers

michal
tomek
marcin
• jon
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMb21a5f363179: [GH Actions] Remove `pull_request` trigger for Android/iOS workflows

Summary

Context: https://phab.comm.dev/D6146#184347

These workflows depend on GitHub Secrets in order to execute properly.
However, secrets aren't available to workflows kicked off from PRs by default for obvious security reasons.

These runs will never succeed anyways, so we should just remove them.

Test Plan

NA

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jan 3 2023, 10:52 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 3 2023, 10:52 AM

We could introduce alternative workflows with flags like CODESIGNING=NO or whatever, but having the certificates and whatnot included helps surface issues as soon as they occur instead of when we make a release.

Harbormaster completed remote builds in B15047: Diff 20528.Jan 3 2023, 11:06 AM

Will the push trigger run after pr merge?

In D6150#184381, @michal wrote:

Will the push trigger run after pr merge?

Yeah, can check the dependabot PRs to verify:

59d4c0.png (688×2 px, 260 KB)

atul attached a referenced file: F315538: 59d4c0.png. (Show Details)Jan 3 2023, 12:54 PM

atul added a reviewer: • jon.Jan 3 2023, 2:26 PM

Fair enough, but it was nice to be able to iterate on these in context of a PR.

Either way if it's not possible, we should remove the "impossible state"

This revision is now accepted and ready to land.Jan 3 2023, 2:35 PM

atul added a reviewer: Restricted Owners Package.Jan 3 2023, 2:38 PM

This revision now requires review to proceed.Jan 3 2023, 2:38 PM

ashoat accepted this revision.Jan 3 2023, 2:44 PM

This revision is now accepted and ready to land.Jan 3 2023, 2:44 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jan 3 2023, 3:01 PM

Closed by commit rCOMMb21a5f363179: [GH Actions] Remove `pull_request` trigger for Android/iOS workflows (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb21a5f363179: [GH Actions] Remove `pull_request` trigger for Android/iOS workflows.

Harbormaster completed remote builds in B15064: Diff 20552.Jan 3 2023, 3:11 PM

Revision Contents
Changeset List

Path

Size

.github/

workflows/

2 lines

2 lines

2 lines

Diff 20553

.github/workflows/android_ci.yml

Loading...

.github/workflows/ios_ci.yml

Loading...

.github/workflows/ios_xctest.yml

Loading...