Page MenuHomePhabricator
Differential D6163

[keyserver] remove old gRPC client
ClosedPublic
Actions

Authored by varun on Jan 4 2023, 7:11 AM.
Tags
None
Referenced Files
F3390175: D6163.diff
Fri, Nov 29, 10:36 PM
Unknown Object (File)
Thu, Nov 28, 11:30 AM
Unknown Object (File)
Thu, Nov 28, 11:30 AM
Unknown Object (File)
Thu, Nov 28, 11:30 AM
Unknown Object (File)
Thu, Nov 28, 4:05 AM
Unknown Object (File)
Tue, Nov 19, 7:07 PM
Unknown Object (File)
Mon, Nov 4, 9:50 AM
Unknown Object (File)
Mon, Nov 4, 9:49 AM
View All Files
Subscribers
ashoat

Details

Reviewers
ashoat
Commits
rCOMM33db22ea20ea: [keyserver] remove old gRPC client
Summary

we're using tonic instead, so we can remove this. it's not used anywhere

Test Plan

ran flow and yarn dev in keyserver folder

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jan 4 2023, 7:11 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 4 2023, 7:11 AM
Harbormaster completed remote builds in B15083: Diff 20574.Jan 4 2023, 7:25 AM
varun requested review of this revision.Jan 4 2023, 7:25 AM
ashoat requested changes to this revision.Jan 4 2023, 6:01 PM

How about the dependencies? Please try to be thorough

This revision now requires changes to proceed.Jan 4 2023, 6:01 PM
varun updated this revision to Diff 20636.Jan 5 2023, 8:52 PM

remove grpc-related dependencies from package.json

ashoat requested changes to this revision.Jan 5 2023, 8:57 PM

How about lib/types/grpc-types? Again, please try to be thorough here – the goal is to remove all of the dead code associated with this deprecated implementation

This revision now requires changes to proceed.Jan 5 2023, 8:57 PM
Harbormaster completed remote builds in B15133: Diff 20636.Jan 5 2023, 9:06 PM
varun updated this revision to Diff 20637.Jan 5 2023, 9:10 PM

delete flow types for grpc-js

varun added a comment.Jan 5 2023, 9:13 PM

Sorry, I'll be more thoughtful and thorough about removing dead code going forward

Harbormaster completed remote builds in B15134: Diff 20637.Jan 5 2023, 9:24 PM
ashoat accepted this revision.Jan 5 2023, 9:40 PM

Thanks!!

varun removed reviewers: tomek, atul.Jan 6 2023, 8:39 AM
This revision is now accepted and ready to land.Jan 6 2023, 8:39 AM
Closed by commit rCOMM33db22ea20ea: [keyserver] remove old gRPC client (authored by varun). · Explain WhyJan 6 2023, 8:41 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM33db22ea20ea: [keyserver] remove old gRPC client.

Revision Contents
Changeset List

PathSize
keyserver/
2 lines
src/
grpc/
42 lines

Diff 20636

View Options

keyserver/package.json

Loading...
View Options

keyserver/src/grpc/grpc-client.js

Loading...
View Options

yarn.lock

Loading...