we plan to use this node addon for more than just exposing opaque-ke, so we should rename it to something more generic.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
As we are going to use a unified rust library for the gRPC client, looks good to me to make these changes.
keyserver/src/rust-node-addon | ||
---|---|---|
2 ↗ | (On Diff #20584) | Can we add a newline here? |
keyserver/src/rust-node-addon | ||
---|---|---|
2 ↗ | (On Diff #20584) | I think this is a symlink |
keyserver/src/rust-node-addon | ||
---|---|---|
2 ↗ | (On Diff #20584) | that's right |
I actually think this is a bit too small. But that's what's in the design.
https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455
@ashoat - I think 16px looks better.