[lib] improve reaction message notification text
ClosedPublic
Actions

Authored by ginsu on Jan 9 2023, 5:14 PM.

Details

Reviewers

atul
tomek
• ashraful
ashoat

Commits

rCOMM7951924621e1: [lib] improve reaction message notification text

Summary

Now that we only notify the author of the target message of a reaction message, we can update the notification text from "USER reacted to a message" to be "USER reacted to your message"

Linear Task: ENG-2616

Depends on D6186

Test Plan

Please review the screenshots to see what my changes look like

Before:

Screenshot 2023-01-09 at 8.08.50 PM.png (1×956 px, 1 MB)

Screenshot 2023-01-09 at 8.08.44 PM.png (1×956 px, 1 MB)

After:

Screenshot 2023-01-09 at 8.10.37 PM.png (1×956 px, 1 MB)

Screenshot 2023-01-09 at 8.10.24 PM.png (1×956 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 9 2023, 5:14 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 9 2023, 5:14 PM

ginsu edited the summary of this revision. (Show Details)Jan 9 2023, 5:16 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, tomek, • ashraful.

ginsu added a parent revision: D6186: [keyserver] reaction messages only notifiy author of target message.

ginsu attached a referenced file: F324364: Screenshot 2023-01-09 at 8.10.24 PM.png. (Show Details)

ginsu attached a referenced file: F324365: Screenshot 2023-01-09 at 8.10.37 PM.png. (Show Details)

ginsu attached a referenced file: F324362: Screenshot 2023-01-09 at 8.08.44 PM.png. (Show Details)

ginsu attached a referenced file: F324363: Screenshot 2023-01-09 at 8.08.50 PM.png. (Show Details)

Harbormaster completed remote builds in B15217: Diff 20746.Jan 9 2023, 5:29 PM

ginsu requested review of this revision.Jan 9 2023, 5:29 PM

tomek accepted this revision.Jan 10 2023, 10:57 AM

tomek added a reviewer: ashoat.

ashoat accepted this revision.Jan 10 2023, 11:54 AM

This revision is now accepted and ready to land.Jan 10 2023, 11:54 AM

Closed by commit rCOMM7951924621e1: [lib] improve reaction message notification text (authored by ginsu). · Explain WhyJan 11 2023, 9:12 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM7951924621e1: [lib] improve reaction message notification text.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

reaction-message-spec.js

4 lines

Diff 20802

View Options

lib/shared/messages/reaction-message-spec.js

[lib] improve reaction message notification textClosedPublicActions