[lib] Remove messageTypeGeneratesNotifs function
ClosedPublic
Actions

Authored by ashoat on Jan 10 2023, 1:28 PM.

Details

Reviewers

Commits

rCOMM5458013b9224: [lib] Remove messageTypeGeneratesNotifs function

Summary

This can be removed following D646, as the function doesn't seem to be doing anything other than adding a layer of indirection now.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 10 2023, 1:28 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptJan 10 2023, 1:28 PM

Harbormaster completed remote builds in B15228: Diff 20758.Jan 10 2023, 1:43 PM

ashoat requested review of this revision.Jan 10 2023, 1:43 PM

ginsu accepted this revision.Jan 10 2023, 1:44 PM

This revision is now accepted and ready to land.Jan 10 2023, 1:44 PM

ashoat added a child revision: D6222: [keyserver] Rename subthreadsCanNotify to userNotMemberOfSubthreads.Jan 10 2023, 3:09 PM

ashoat edited the summary of this revision. (Show Details)Jan 10 2023, 3:12 PM

Closed by commit rCOMM5458013b9224: [lib] Remove messageTypeGeneratesNotifs function (authored by ashoat). · Explain WhyJan 10 2023, 6:54 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5458013b9224: [lib] Remove messageTypeGeneratesNotifs function.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

message-creator.js

4 lines

lib/

shared/

message-utils.js

6 lines

Diff 20772

View Options

keyserver/src/creators/message-creator.js