Paths

Table of Contentst

Differential D6252

[services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust
ClosedPublic
Actions

Authored by • max on Jan 12 2023, 8:04 AM.

Tags

None

Referenced Files

	F3244020: D6252.id21749.diff
	Thu, Nov 14, 10:28 AM

	Unknown Object (File)
	Tue, Nov 12, 1:22 AM

	Unknown Object (File)
	Fri, Nov 8, 10:03 AM

	Unknown Object (File)
	Fri, Nov 8, 3:57 AM

	Unknown Object (File)
	Sat, Oct 26, 9:58 PM

	Unknown Object (File)
	Sat, Oct 26, 9:58 PM

	Unknown Object (File)
	Sat, Oct 26, 9:58 PM

	Unknown Object (File)
	Sat, Oct 26, 9:58 PM

Subscribers

Details

Reviewers

• jon
bartek

Commits

rCOMMf8a59aa046e2: [services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust

Summary

This function exposes the isConfigParameterSet function from the C++ codebase to the Rust by using the CXX function.
This function will be used in the next D6253 diff to retrieve the boolean status if the config file flag.

Linear task: ENG-2642

Test Plan

Adding the skip_authentication flag to the [sessions] section of the config file results in a true return from the isConfigParameterSet('sessions.skip_authentication') function call from the Rust codebase.

Diff Detail

Repository

Branch

expose-skip-auth-config

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jan 12 2023, 8:04 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptJan 12 2023, 8:04 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D6251: [services] Tunnelbroker - Add skip authentication config parameter.Jan 12 2023, 8:06 AM

• max added a child revision: D6253: [services] Tunnelbroker - Skipping session checks in a stream when `skip_authentication` flag is set.

• max edited the summary of this revision. (Show Details)Jan 12 2023, 8:15 AM

• max edited the test plan for this revision. (Show Details)

• max added a reviewer: bartek. • max added 1 blocking reviewer(s): • jon.

Harbormaster completed remote builds in B15298: Diff 20873.Jan 12 2023, 8:19 AM

• max published this revision for review.Jan 12 2023, 8:22 AM

• jon accepted this revision.Jan 12 2023, 11:30 AM

This revision is now accepted and ready to land.Jan 12 2023, 11:30 AM

bartek accepted this revision.Jan 12 2023, 11:37 AM

Rebasing on parent changes.

Harbormaster completed remote builds in B15924: Diff 21736.Feb 1 2023, 4:09 AM

Rebasing on master.

Harbormaster completed remote builds in B15925: Diff 21744.Feb 1 2023, 4:54 AM

Closed by commit rCOMMf8a59aa046e2: [services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust (authored by • max). · Explain WhyFeb 1 2023, 5:57 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMf8a59aa046e2: [services] Tunnelbroker - Expose `isConfigParameterSet` function to the Rust.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

1 line

libcpp/

1 line

Tunnelbroker.cpp

5 lines

Diff 20873

services/tunnelbroker/src/cxx_bridge.rs

Loading...

services/tunnelbroker/src/libcpp/Tunnelbroker.h

Loading...

services/tunnelbroker/src/libcpp/Tunnelbroker.cpp

Loading...