Page MenuHomePhabricator
Differential D6490

[services] Tunnelbroker - Add disable notifications config parameter
ClosedPublic
Actions

Authored by • max on Feb 1 2023, 3:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 1:16 PM
Unknown Object (File)
Wed, Mar 12, 10:52 AM
Unknown Object (File)
Feb 25 2025, 7:29 AM
Unknown Object (File)
Feb 16 2025, 5:53 AM
Unknown Object (File)
Feb 16 2025, 5:53 AM
Unknown Object (File)
Feb 16 2025, 5:53 AM
Unknown Object (File)
Feb 16 2025, 5:53 AM
Unknown Object (File)
Feb 16 2025, 5:50 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMM24dedc711dcb: [services] Tunnelbroker - Add disable notifications config parameter
Summary

This diff introduces adding the notifications.disable config flag to disable the push notifications mechanism in a Tunnelbroker.

Linear task: ENG-2639

Test Plan

Adding the disable flag to the [notifications] section of the config file results in a true return from the isParameterSet('notifications.disable') function call.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Feb 1 2023, 3:25 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptFeb 1 2023, 3:25 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript
• max added a parent revision: D6251: [services] Tunnelbroker - Add skip authentication config parameter.Feb 1 2023, 3:26 AM
• max edited parent revisions, added: D6253: [services] Tunnelbroker - Skipping session checks in a stream when `skip_authentication` flag is set; removed: D6251: [services] Tunnelbroker - Add skip authentication config parameter.Feb 1 2023, 3:36 AM
Harbormaster completed remote builds in B15922: Diff 21733.Feb 1 2023, 3:38 AM
• max published this revision for review.Feb 1 2023, 3:39 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: bartek.
• max edited the summary of this revision. (Show Details)
bartek accepted this revision.Feb 1 2023, 4:28 AM
This revision is now accepted and ready to land.Feb 1 2023, 4:28 AM
• max edited the summary of this revision. (Show Details)Feb 6 2023, 5:15 AM
• max edited the test plan for this revision. (Show Details)
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max updated this revision to Diff 22991.Feb 23 2023, 5:32 AM
• max edited the summary of this revision. (Show Details)

Rebasing on master, parent changes and D6749 fix.

• max added a child revision: D6850: [services] Tunnelbroker - Skipping sending notif token request when notifications are off by the config flag.Feb 23 2023, 5:41 AM
Harbormaster completed remote builds in B16817: Diff 22991.Feb 23 2023, 5:47 AM
Closed by commit rCOMM24dedc711dcb: [services] Tunnelbroker - Add disable notifications config parameter (authored by • max). · Explain WhyFeb 23 2023, 6:13 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM24dedc711dcb: [services] Tunnelbroker - Add disable notifications config parameter.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
libcpp/
src/
Tools/
1 line
6 lines

Diff 22996

View Options

services/tunnelbroker/src/libcpp/src/Tools/ConfigManager.h

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { Switch, Text, View } from 'react-native'; import { Alert, Switch, Text, View } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler'; import { ScrollView } from 'react-native-gesture-handler';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { getMessageForException } from 'lib/utils/errors.js';
import { entries } from 'lib/utils/objects.js';
import { useClientBackup } from '../backup/use-client-backup.js';
import Button from '../components/button.react.js';
import { setLocalSettingsActionType } from '../redux/action-types.js'; import { setLocalSettingsActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useColors, useStyles } from '../themes/colors.js';
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function BackupMenu(props: { ... }): React.Node { function BackupMenu(props: { ... }): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const colors = useColors();
const userStore = useSelector(state => state.userStore);
const isBackupEnabled = useSelector( const isBackupEnabled = useSelector(
state => state.localSettings.isBackupEnabled, state => state.localSettings.isBackupEnabled,
); );
const { restoreBackupProtocol } = useClientBackup();
const testRestore = React.useCallback(async () => {
let message;
try {
const result = await restoreBackupProtocol({ userStore });
message = entries(result)
.map(([key, value]) => `${key}: ${String(value)}`)
.join('\n');
} catch (e) {
console.error(`Backup uploading error: ${e}`);
message = `Backup restore error: ${String(getMessageForException(e))}`;
}
Alert.alert('Restore protocol result', message);
}, [restoreBackupProtocol, userStore]);
const onBackupToggled = React.useCallback( const onBackupToggled = React.useCallback(
value => { value => {
dispatch({ dispatch({
type: setLocalSettingsActionType, type: setLocalSettingsActionType,
payload: { isBackupEnabled: value }, payload: { isBackupEnabled: value },
}); });
}, },
[dispatch], [dispatch],
); );
return ( return (
<ScrollView <ScrollView
contentContainerStyle={styles.scrollViewContentContainer} contentContainerStyle={styles.scrollViewContentContainer}
style={styles.scrollView} style={styles.scrollView}
> >
<Text style={styles.header}>SETTINGS</Text> <Text style={styles.header}>SETTINGS</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.submenuButton}> <View style={styles.submenuButton}>
<Text style={styles.submenuText}>Toggle automatic backup</Text> <Text style={styles.submenuText}>Toggle automatic backup</Text>
<Switch value={isBackupEnabled} onValueChange={onBackupToggled} /> <Switch value={isBackupEnabled} onValueChange={onBackupToggled} />
</View> </View>
</View> </View>
<Text style={styles.header}>ACTIONS</Text>
<View style={styles.section}>
<Button
onPress={testRestore}
style={styles.row}
iosFormat="highlight"
iosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}
iosActiveOpacity={0.85}
>
<Text style={styles.submenuText}>Test backup restore protocol</Text>
</Button>
</View>
</ScrollView> </ScrollView>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: { scrollViewContentContainer: {
paddingTop: 24, paddingTop: 24,
}, },
Show All 21 Lines submenuButton: {
paddingVertical: 10, paddingVertical: 10,
alignItems: 'center', alignItems: 'center',
}, },
submenuText: { submenuText: {
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
flex: 1, flex: 1,
fontSize: 16, fontSize: 16,
}, },
row: {
flexDirection: 'row',
justifyContent: 'space-between',
paddingHorizontal: 24,
paddingVertical: 14,
},
}; };
export default BackupMenu; export default BackupMenu;
View Options

services/tunnelbroker/src/libcpp/src/Tools/ConfigManager.cpp

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { Switch, Text, View } from 'react-native'; import { Alert, Switch, Text, View } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler'; import { ScrollView } from 'react-native-gesture-handler';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { getMessageForException } from 'lib/utils/errors.js';
import { entries } from 'lib/utils/objects.js';
import { useClientBackup } from '../backup/use-client-backup.js';
import Button from '../components/button.react.js';
import { setLocalSettingsActionType } from '../redux/action-types.js'; import { setLocalSettingsActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useColors, useStyles } from '../themes/colors.js';
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function BackupMenu(props: { ... }): React.Node { function BackupMenu(props: { ... }): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const colors = useColors();
const userStore = useSelector(state => state.userStore);
const isBackupEnabled = useSelector( const isBackupEnabled = useSelector(
state => state.localSettings.isBackupEnabled, state => state.localSettings.isBackupEnabled,
); );
const { restoreBackupProtocol } = useClientBackup();
const testRestore = React.useCallback(async () => {
let message;
try {
const result = await restoreBackupProtocol({ userStore });
message = entries(result)
.map(([key, value]) => `${key}: ${String(value)}`)
.join('\n');
} catch (e) {
console.error(`Backup uploading error: ${e}`);
message = `Backup restore error: ${String(getMessageForException(e))}`;
}
Alert.alert('Restore protocol result', message);
}, [restoreBackupProtocol, userStore]);
const onBackupToggled = React.useCallback( const onBackupToggled = React.useCallback(
value => { value => {
dispatch({ dispatch({
type: setLocalSettingsActionType, type: setLocalSettingsActionType,
payload: { isBackupEnabled: value }, payload: { isBackupEnabled: value },
}); });
}, },
[dispatch], [dispatch],
); );
return ( return (
<ScrollView <ScrollView
contentContainerStyle={styles.scrollViewContentContainer} contentContainerStyle={styles.scrollViewContentContainer}
style={styles.scrollView} style={styles.scrollView}
> >
<Text style={styles.header}>SETTINGS</Text> <Text style={styles.header}>SETTINGS</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.submenuButton}> <View style={styles.submenuButton}>
<Text style={styles.submenuText}>Toggle automatic backup</Text> <Text style={styles.submenuText}>Toggle automatic backup</Text>
<Switch value={isBackupEnabled} onValueChange={onBackupToggled} /> <Switch value={isBackupEnabled} onValueChange={onBackupToggled} />
</View> </View>
</View> </View>
<Text style={styles.header}>ACTIONS</Text>
<View style={styles.section}>
<Button
onPress={testRestore}
style={styles.row}
iosFormat="highlight"
iosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}
iosActiveOpacity={0.85}
>
<Text style={styles.submenuText}>Test backup restore protocol</Text>
</Button>
</View>
</ScrollView> </ScrollView>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: { scrollViewContentContainer: {
paddingTop: 24, paddingTop: 24,
}, },
Show All 21 Lines submenuButton: {
paddingVertical: 10, paddingVertical: 10,
alignItems: 'center', alignItems: 'center',
}, },
submenuText: { submenuText: {
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
flex: 1, flex: 1,
fontSize: 16, fontSize: 16,
}, },
row: {
flexDirection: 'row',
justifyContent: 'space-between',
paddingHorizontal: 24,
paddingVertical: 14,
},
}; };
export default BackupMenu; export default BackupMenu;