Page MenuHomePhabricator

[CI] Prevent all protobuf tests from being build
ClosedPublic

Authored by jon on Jan 17 2023, 7:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:10 AM
Unknown Object (File)
Fri, Nov 8, 10:09 AM
Unknown Object (File)
Fri, Nov 8, 10:09 AM
Unknown Object (File)
Fri, Nov 8, 10:09 AM
Unknown Object (File)
Tue, Oct 29, 11:22 PM
Unknown Object (File)
Tue, Oct 29, 11:22 PM
Unknown Object (File)
Tue, Oct 29, 11:22 PM
Unknown Object (File)
Tue, Oct 29, 11:20 PM
Subscribers

Details

Summary

Although BUILD_TESTING is referenced in some of the
cmake logic for protobuf, the main switch is protobuf_BUILD_TESTS.

Part of https://linear.app/comm/issue/ENG-2721/

Test Plan

CI gate should not build the testing executable

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

From the logs, no testing target being built:

[ 98%] Building CXX object CMakeFiles/libprotoc.dir/workdir/protobuf/src/google/protobuf/compiler/zip_writer.cc.o
[ 98%] Linking CXX shared library libprotoc.so
[ 98%] Built target libprotoc
[ 99%] Building CXX object CMakeFiles/protoc.dir/workdir/protobuf/src/google/protobuf/compiler/main.cc.o
[100%] Linking CXX executable protoc
[100%] Built target protoc
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/lib/libprotobuf-lite.so.3.15.8.0
-- Set runtime path of "/usr/local/lib/libprotobuf-lite.so.3.15.8.0" to "$ORIGIN"
-- Installing: /usr/local/lib/libprotobuf-lite.so
-- Installing: /usr/local/lib/libprotobuf.so.3.15.8.0
-- Set runtime path of "/usr/local/lib/libprotobuf.so.3.15.8.0" to "$ORIGIN"
-- Installing: /usr/local/lib/libprotobuf.so
-- Installing: /usr/local/lib/libprotoc.so.3.15.8.0
-- Set runtime path of "/usr/local/lib/libprotoc.so.3.15.8.0" to "$ORIGIN"
-- Installing: /usr/local/lib/libprotoc.so
-- Installing: /usr/local/bin/protoc-3.15.8.0
-- Installing: /usr/local/bin/protoc
This revision is now accepted and ready to land.Jan 17 2023, 8:26 AM