Paths

Table of Contentst

Differential D6311

[Direnv] Use nix-direnv if possible
ClosedPublic
Actions

Authored by • jon on Jan 19 2023, 10:47 AM.

Tags

None

Referenced Files

	F3490132: D6311.diff
	Wed, Dec 18, 3:08 PM

	Unknown Object (File)
	Tue, Dec 17, 6:49 AM

	Unknown Object (File)
	Tue, Dec 17, 6:49 AM

	Unknown Object (File)
	Tue, Dec 17, 6:48 AM

	Unknown Object (File)
	Tue, Dec 17, 6:47 AM

	Unknown Object (File)
	Nov 18 2024, 8:27 AM

	Unknown Object (File)
	Nov 10 2024, 10:02 AM

	Unknown Object (File)
	Oct 29 2024, 11:21 PM

View All 64 Files

Subscribers

Details

Reviewers

atul
ashoat
varun

Commits

rCOMMe58a23478a57: [Direnv] Use nix-direnv if possible

Summary

nix-direnv has better amoritorized costs for initiating a shell.

Part of https://linear.app/comm/issue/ENG-2751

Test Plan

Install direnv, script being added in later diff

direnv allow .
cd ..
cd comm
# might be slow on first execution

cd ..
cd comm
# all following executions of direnv should be relatively fast

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jan 19 2023, 10:47 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 19 2023, 10:47 AM

Harbormaster completed remote builds in B15480: Diff 21117.Jan 19 2023, 11:02 AM

• jon requested review of this revision.Jan 19 2023, 11:02 AM

• jon added a child revision: D6313: [Nix] Install homebrew on nix develop.Jan 19 2023, 11:59 AM

Will let @atul do the final accept since he's the one having issues – curious if it resolves them

Yup, things are snappier now (specifically the first time the directory is cd'd into after a change has been made in the working copy)

This revision is now accepted and ready to land.Jan 19 2023, 9:37 PM

Closed by commit rCOMMe58a23478a57: [Direnv] Use nix-direnv if possible (authored by • jon). · Explain WhyJan 23 2023, 7:16 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMe58a23478a57: [Direnv] Use nix-direnv if possible.

Revision Contents
Changeset List

Path

Size

4 lines

Diff 21191

.envrc

Loading...