[Nix] Install homebrew on nix develop
ClosedPublic
Actions

Authored by • jon on Jan 19 2023, 11:59 AM.

Details

Reviewers

varun
atul
bartek

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMMdb7f5c0ff667: [Nix] Install homebrew on nix develop

Summary

It's needed for reactotron and potentially direnv.
Since Homebrew is easy to install through the command line,
may as well automate the process if it's missing

Depends on D6311

https://linear.app/comm/issue/ENG-2752

Test Plan

In new terminal:

# Remove /usr/local/bin from path, which is where homebrew is normally installed
export PATH=/usr/bin
# Bring in bash not from /usr/local/bin
. <(/nix/var/nix/profiles/default/bin/nix print-dev-env .#devShell)

./scripts/install_homebrew_macos.sh
# Should install homebrew, can be ran if homebrew is already installed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jan 19 2023, 11:59 AM

Owners added a reviewer: Restricted Owners Package.Jan 19 2023, 11:59 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 19 2023, 11:59 AM

• jon edited the summary of this revision. (Show Details)Jan 19 2023, 12:00 PM

Harbormaster completed remote builds in B15482: Diff 21121.Jan 19 2023, 12:13 PM

• jon requested review of this revision.Jan 19 2023, 12:13 PM

• jon added a child revision: D6315: [Nix] Prompt user to install direnv.Jan 19 2023, 12:57 PM

Shouldn't matter much in the context of this particular diff, just a side note when looking at the test plan. In non-M1 mac, Homebrew uses /usr/local/bin, but for M1 (Apple silicon in general) it is /opt/homebrew/bin

Shouldn't matter much in the context of this particular diff, just a side note when looking at the test plan. In non-M1 mac, Homebrew uses /usr/local/bin, but for M1 (Apple silicon in general) it is /opt/homebrew/bin

Fun. :)

atul accepted this revision.Jan 20 2023, 5:20 PM

varun accepted this revision.Jan 23 2023, 10:25 AM

This revision is now accepted and ready to land.Jan 23 2023, 10:25 AM

Closed by commit rCOMMdb7f5c0ff667: [Nix] Install homebrew on nix develop (authored by • jon). · Explain WhyJan 23 2023, 10:45 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMdb7f5c0ff667: [Nix] Install homebrew on nix develop.

will mentioned this in D12777: [nix] Replaces brew install of watchman with nix.Jul 16 2024, 12:12 PM