[web] Don't show option to change password for SIWE accounts
ClosedPublic
Actions

Authored by atul on Jan 24 2023, 12:26 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM8c7b9c526908: [web] Don't show option to change password for SIWE accounts

Summary

Pretty straightforward, we just hide this setting for accounts that have signed in with Ethereum (based solely on accountHasPassword check).

Test Plan

SIWE Account:

"Traditional" account:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 24 2023, 12:26 PM

atul published this revision for review.Jan 24 2023, 12:26 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B15594: Diff 21260.Jan 24 2023, 12:41 PM

ashoat accepted this revision.Jan 24 2023, 2:44 PM

This revision is now accepted and ready to land.Jan 24 2023, 2:44 PM

rebase before landign

Harbormaster completed remote builds in B15640: Diff 21321.Jan 25 2023, 7:48 AM

Closed by commit rCOMM8c7b9c526908: [web] Don't show option to change password for SIWE accounts (authored by atul). · Explain WhyJan 25 2023, 7:48 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8c7b9c526908: [web] Don't show option to change password for SIWE accounts.

Revision Contents
Changeset List

Path

Size

web/

settings/

account-settings.react.js

33 lines

Diff 21321

View Options

web/settings/account-settings.react.js

[web] Don't show option to change password for SIWE accountsClosedPublicActions