Page MenuHomePhabricator
Differential D6409

[lib] bump emoji-regex version to 10.2.1
ClosedPublic
Actions

Authored by ginsu on Jan 26 2023, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 12:36 PM
Unknown Object (File)
Tue, Oct 29, 8:23 PM
Unknown Object (File)
Tue, Oct 29, 8:23 PM
Unknown Object (File)
Tue, Oct 29, 8:22 PM
Unknown Object (File)
Tue, Oct 29, 8:20 PM
Unknown Object (File)
Sun, Oct 27, 3:43 PM
Unknown Object (File)
Oct 1 2024, 3:29 AM
Unknown Object (File)
Sep 30 2024, 6:51 AM
View All 49 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM25ee6809e5bf: [lib] bump emoji-regex version to 10.2.1
Summary

bumped emoji-regex to 10.2.1. This new version updates the emoji version from 13 to 14. The import statement also changed in this new version, so needed to make the necessary changes in lib/shared/emojis.js. I bumped the version by manually changing the number in package.json in lib and ran yarn cleaninstall

Context on the import changes from 9.2 => 10.2

emoji-regex v 9.2
emoji-regex v 10.2

Test Plan

onlyEmojiRegex work as expected, and will be adding jest tests to subsequent diff to further test onlyOneEmojiRegex

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 26 2023, 4:07 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 26 2023, 4:07 PM
ginsu edited the summary of this revision. (Show Details)Jan 26 2023, 4:09 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat.
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)Jan 26 2023, 4:12 PM
ginsu added a child revision: D6398: [keyserver] change reaction type from just like emoji to any emoji.
ginsu added inline comments.
yarn.lock
9726–9739

Noticed that previous versions of emoji-regex are still in the yarn lock... Is this something we should delete?

Harbormaster completed remote builds in B15698: Diff 21403.Jan 26 2023, 4:22 PM
ginsu requested review of this revision.Jan 26 2023, 4:22 PM
ashoat accepted this revision.Jan 26 2023, 5:45 PM
ashoat added inline comments.
yarn.lock
9726–9739

See yarn why emoji-regex – it's a transitive dependency of a lot of other packages

This revision is now accepted and ready to land.Jan 26 2023, 5:45 PM
ginsu added inline comments.Jan 26 2023, 8:02 PM
yarn.lock
9726–9739

that's a sick trick thanks for sharing!

Closed by commit rCOMM25ee6809e5bf: [lib] bump emoji-regex version to 10.2.1 (authored by ginsu). · Explain WhyJan 26 2023, 8:11 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM25ee6809e5bf: [lib] bump emoji-regex version to 10.2.1.

Revision Contents
Changeset List

PathSize
lib/
2 lines
shared/
4 lines
7 lines

Diff 21403

View Options

lib/package.json

Loading...
View Options

lib/shared/emojis.js

Loading...
View Options

yarn.lock

Loading...