[native] change location to tooltipLocation in the TooltipParams
ClosedPublic
Actions

Authored by ginsu on Jan 29 2023, 2:51 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM8d26192f6362: [native] change location to tooltipLocation in the TooltipParams

Summary

change location to tooltipLocation in the TooltipParams. Planning to introduce location logic for the reaction selection popover, so wanted to change this name to prepare for that

Depends on D6445
Linear Task: ENG-2779

Test Plan

flow and will be further tested in a subsequent diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 29 2023, 2:51 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 29 2023, 2:51 PM

ginsu edited the summary of this revision. (Show Details)Jan 29 2023, 2:57 PM

ginsu added reviewers: atul, tomek.

ginsu added a parent revision: D6445: [native] introduce showEmojiKeyboard shared value.

Harbormaster completed remote builds in B15790: Diff 21536.Jan 29 2023, 3:05 PM

ginsu requested review of this revision.Jan 29 2023, 3:05 PM

ginsu added a child revision: D6448: [native] introduce canCreateReactionFromMessage prop to Tooltip component.Jan 29 2023, 3:09 PM

Is this diff going to crash any dev app that has saved navigation state with an open tooltip?

This revision is now accepted and ready to land.Jan 30 2023, 4:43 AM

In D6447#193203, @tomek wrote:

Is this diff going to crash any dev app that has saved navigation state with an open tooltip?

It won't crash the dev app; however, if a dev was in this scenario you describe above when they open up the app for the first time after pulling changes, they will experience the following: