Page MenuHomePhabricator
Differential D6456

[native] remove Like button from tooltip
ClosedPublic
Actions

Authored by ginsu on Jan 29 2023, 9:42 PM.
Tags
None
Referenced Files
F3490104: D6456.diff
Wed, Dec 18, 2:56 PM
Unknown Object (File)
Fri, Dec 6, 12:24 PM
Unknown Object (File)
Fri, Nov 22, 11:52 PM
Unknown Object (File)
Nov 15 2024, 10:58 PM
Unknown Object (File)
Nov 15 2024, 10:43 PM
Unknown Object (File)
Nov 15 2024, 10:42 PM
Unknown Object (File)
Nov 8 2024, 3:10 AM
Unknown Object (File)
Nov 8 2024, 3:10 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
Commits
rCOMM493c19843488: [native] remove Like button from tooltip
Summary

removed like button from tooltip now that we have full emoji support on the reaction selection popover

Depends on D6455
Linear Task: ENG-2778

Test Plan

Please watch the demo videos to see the changes I made

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 29 2023, 9:42 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 29 2023, 9:42 PM
ginsu edited the summary of this revision. (Show Details)Jan 29 2023, 9:47 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, tomek.
ginsu added a parent revision: D6455: [native] implement emoji keyboard button on reaction selection popover.
ginsu attached a referenced file: F350954: Screen Recording 2023-01-30 at 12.44.36 AM.mov. (Show Details)
ginsu attached a referenced file: F350953: Screen Recording 2023-01-30 at 12.40.48 AM.mov. (Show Details)
Harbormaster completed remote builds in B15804: Diff 21550.Jan 29 2023, 9:56 PM
ginsu requested review of this revision.Jan 29 2023, 9:56 PM
tomek accepted this revision.Jan 30 2023, 6:09 AM
This revision is now accepted and ready to land.Jan 30 2023, 6:09 AM
ginsu updated this revision to Diff 21719.Jan 31 2023, 3:04 PM

remove sendReaction function from reaction-message-utils

Harbormaster completed remote builds in B15913: Diff 21719.Jan 31 2023, 3:24 PM
ginsu updated this revision to Diff 21863.Feb 2 2023, 8:56 AM

rebase before landing

Harbormaster completed remote builds in B16018: Diff 21863.Feb 2 2023, 9:10 AM
Closed by commit rCOMM493c19843488: [native] remove Like button from tooltip (authored by ginsu). · Explain WhyFeb 2 2023, 10:59 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM493c19843488: [native] remove Like button from tooltip.

Revision Contents
Changeset List

Diff 21863

View Options

native/chat/multimedia-message-tooltip-modal.react.js

Loading...
View Options

native/chat/multimedia-message.react.js

Loading...
View Options

native/chat/reaction-message-utils.js

Loading...
View Options

native/chat/robotext-message-tooltip-modal.react.js

Loading...
View Options

native/chat/robotext-message.react.js

Loading...
View Options

native/chat/text-message-tooltip-modal.react.js

Loading...
View Options

native/chat/text-message.react.js

Loading...
View Options

native/navigation/tooltip.react.js

Loading...