issue: https://linear.app/comm/issue/ENG-2794/make-it-possible-to-display-only-chats-from-a-given-community-in-the
In D6457 I added architectural changes that allow for a new type of calendar filter. In this diff I address these changes in the CalendarFiltersReducer, by handling the new type of action. What we want to
happen, is for the calnderFilters in the redux store, to be set to: the calendra filters of other types as they used to be + calendar filter of type COMMUNITY to have threadIDs equal to threadIDs
from the actions payload.
Details
Details
Dispatch updateCalendarCommunityFilter and clearCalendarCommunityFilter actions, check in redux tools that they succeed, and redux state changes as expected.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
We are not sending the community filter to the keyserver anymore, so the information about the filter is only present on web. So handling it should also be done on web. The selector is no longer needed,
since the filter is not part of the other filters, that are present on the keyserver
Comment Actions
I messed up something in my local copy, and cannot get this commit back.
I'm abandoning this one and in it's place the is D6645. Sorry
Comment Actions
This should never be necessary. You can always get a commit back via yarn arcpatch. You can also always update the diff you want by including the text "Differential Revision: https://phab.comm.dev/D6458" in the commit text. Worth reading through this section of our docs.
Separately, I strongly encourage you to examine how your local environment got in this state... you're probably using some "antipatterns" where you often find yourself with multiple commits for a given revision or something like that. You should always have precisely one commit in your local copy corresponding to a diff.