Paths

Table of Contentst

Differential D6646

[web] Make pressing a drawer item in calendar tab change available filters
ClosedPublic
Actions

Authored by inka on Feb 7 2023, 6:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 5:48 PM

	Unknown Object (File)
	Tue, Oct 29, 11:03 AM

	Unknown Object (File)
	Mon, Oct 28, 6:39 PM

	Unknown Object (File)
	Mon, Oct 28, 3:03 AM

	Unknown Object (File)
	Mon, Oct 28, 3:03 AM

	Unknown Object (File)
	Mon, Oct 28, 3:03 AM

	Unknown Object (File)
	Mon, Oct 28, 3:03 AM

	Unknown Object (File)
	Mon, Oct 28, 3:03 AM

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM97384531f943: [web] Make pressing a drawer item in calendar tab change available filters

Summary

issue: https://linear.app/comm/issue/ENG-2793/make-calendar-filters-change-on-drawer-action
We want pressing on a community drawer item, in the calendar tab, to result in only events from chats from that community being displayed, and additionally only chats from this community being present in
the filter panel.
CalendarDrawerItemHandler is a component, that provides a handler object, that has the onClick function for the drawer items for the calendar tab (D6287). This diff changes what this 'onClick' function does, to satisfy the requirement from above.

Test Plan

Run web app, checked that pressing on an item in the community drawer results in only events from chats from that community being displayed, and only chats from this community being present
in the filter panel.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Feb 7 2023, 6:38 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 7 2023, 6:38 AM

inka added a parent revision: D6462: [web] Add logic for displaying only chats from a given community in calendar filters.Feb 7 2023, 6:39 AM

inka added a parent revision: D6287: [web] Add community drawer item handlers.

inka removed a parent revision: D6287: [web] Add community drawer item handlers.

inka edited the summary of this revision. (Show Details)Feb 7 2023, 6:41 AM

Harbormaster completed remote builds in B16220: Diff 22185.Feb 7 2023, 6:52 AM

inka requested review of this revision.Feb 7 2023, 6:52 AM

Changes due to: chainng what is kept in the redux state - keep only the community id

Harbormaster completed remote builds in B16270: Diff 22261.Feb 8 2023, 2:23 AM

kamil accepted this revision.Feb 8 2023, 8:45 AM

This revision is now accepted and ready to land.Feb 8 2023, 8:45 AM

Move selector to web/selectors/calendar-selectors.js

Harbormaster completed remote builds in B16299: Diff 22299.Feb 9 2023, 8:32 AM

Rebase, fix rebasing mistake

Harbormaster completed remote builds in B16306: Diff 22306.Feb 9 2023, 10:29 AM

Rebase

Harbormaster failed remote builds in B16422: Diff 22459!Feb 13 2023, 7:39 AM

Rebase

Trying to fix my local copy

Trying to fix my local copy

Harbormaster completed remote builds in B16440: Diff 22477.Feb 13 2023, 9:58 AM

Harbormaster completed remote builds in B16443: Diff 22480.Feb 13 2023, 10:10 AM

Harbormaster completed remote builds in B16444: Diff 22481.Feb 13 2023, 10:12 AM

Rebase

Harbormaster completed remote builds in B16500: Diff 22547.Feb 14 2023, 4:00 AM

Closed by commit rCOMM97384531f943: [web] Make pressing a drawer item in calendar tab change available filters (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:02 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM97384531f943: [web] Make pressing a drawer item in calendar tab change available filters.

Revision Contents
Changeset List

Path

Size

web/

sidebar/

community-drawer-item-handlers.react.js

22 lines

Diff 22587

web/sidebar/community-drawer-item-handlers.react.js

Loading...