[Services] Use clap to provide configurable cli experience to blob service
ClosedPublic
Actions

Authored by • jon on Jan 30 2023, 7:20 AM.

Details

Reviewers

bartek
varun
• max

Commits

rCOMMa9c0e4be3baf: [Services] Use clap to provide configurable cli experience to blob service

Summary

Blob service should be able to be configured through environment
variables and arguments. This enables this scenario for the grpc port and
localstack url.

https://linear.app/comm/issue/ENG-2310

Depends on D6463

Test Plan

RUST_LOG=debug cargo run -- --port 50050 # should see aws config logic
sudo lsof -i -P | grep LISTEN | grep 50050 # should see process bound to port

Integration tests need additional work to test integration more thoroughly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jan 30 2023, 7:20 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 30 2023, 7:20 AM

Harbormaster completed remote builds in B15849: Diff 21615.Jan 30 2023, 7:31 AM

• jon requested review of this revision.Jan 30 2023, 7:31 AM

Glad to see this in Blob service too!

Integration tests need additional work to test integration more thoroughly.

Btw, do you have any plans/ideas on how to tidy up the whole services infra config?

services/blob/src/config.rs
28–30 ↗	(On Diff #21615)	I forgot to run Clippy the time I implemented this in Backup service, but it suggested to do this. But there's already a separate task for Clippy fixes so up to you