Page MenuHomePhabricator
Differential D6487

[native] introduce useSendReaction hook
ClosedPublic
Actions

Authored by ginsu on Jan 31 2023, 1:05 PM.
Tags
None
Referenced Files
F3489145: D6487.diff
Wed, Dec 18, 11:43 AM
Unknown Object (File)
Tue, Dec 3, 3:32 AM
Unknown Object (File)
Nov 15 2024, 9:48 PM
Unknown Object (File)
Nov 15 2024, 8:07 PM
Unknown Object (File)
Nov 15 2024, 7:39 PM
Unknown Object (File)
Nov 8 2024, 3:31 AM
Unknown Object (File)
Nov 8 2024, 3:31 AM
Unknown Object (File)
Nov 8 2024, 3:31 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
Commits
rCOMMfa4110a3b78a: [native] introduce useSendReaction hook
Summary

introduce useSendReaction hook. This hook will eventually be used in the following files

  1. native/chat/text-message-tooltip-button.react
  2. native/chat/multimedia-message-tooltip-button.react
  3. native/chat/robotext-message-tooltip-button.react.

This hook will also eventually replace onPressReact and sendReaction in reaction-message-utils; however, it is not safe to remove it yet because the like button in the tooltip still calls these functions, but we will address this in a subsequent diff

Depends on D6453
Linear Task: ENG-2779

Test Plan

flow and this diff will be further tested in subsequent diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 31 2023, 1:05 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 31 2023, 1:05 PM
ginsu edited the summary of this revision. (Show Details)Jan 31 2023, 1:12 PM
ginsu added reviewers: atul, tomek.
ginsu added a parent revision: D6453: [native] introduce useReactionSelectionPopoverPosition hook.
Harbormaster completed remote builds in B15905: Diff 21711.Jan 31 2023, 1:30 PM
ginsu requested review of this revision.Jan 31 2023, 1:30 PM
ginsu added a child revision: D6454: [native] introduce reaction selection popover component.Jan 31 2023, 1:40 PM
tomek accepted this revision.Feb 1 2023, 2:43 AM
This revision is now accepted and ready to land.Feb 1 2023, 2:43 AM
ginsu updated this revision to Diff 21787.Feb 1 2023, 1:13 PM

rebase for changes needed in D6455

Harbormaster completed remote builds in B15955: Diff 21787.Feb 1 2023, 1:32 PM
ginsu updated this revision to Diff 21796.Feb 1 2023, 1:40 PM

rebase before landing

Harbormaster completed remote builds in B15960: Diff 21796.Feb 1 2023, 2:02 PM
Closed by commit rCOMMfa4110a3b78a: [native] introduce useSendReaction hook (authored by ginsu). · Explain WhyFeb 1 2023, 2:11 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfa4110a3b78a: [native] introduce useSendReaction hook.

Revision Contents
Changeset List

PathSize
native/
chat/
94 lines

Diff 21810

View Options

native/chat/reaction-message-utils.js

Loading...