Paths

Table of Contentst

[web] Pull `SIWEButton` out of `SIWE` component
ClosedPublic
Actions

Authored by atul on Jan 31 2023, 1:39 PM.

Details

Reviewers

ashoat
tomek
ginsu
rohan

Commits

rCOMM3e9b71d2c1e0: [web] Pull `SIWEButton` out of `SIWE` component

Summary

We introduce SIWEButton and continue to use as-is in SIWE component.

In subsequent diff we'll move SIWEButton out of SIWE into LoginForm so it can be used independently (just to initiate the SIWE auth flow).

Depends on D6488

Test Plan

This diff is a noop, tested the SIWE web flow and things continue to work as they did before.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D6489 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 31 2023, 1:39 PM

atul published this revision for review.Jan 31 2023, 1:43 PM

atul edited the summary of this revision. (Show Details)

atul added a parent revision: D6488: [web] Lift `RainbowKitProvider` "above" `LoginForm`.

Harbormaster completed remote builds in B15908: Diff 21714.Jan 31 2023, 2:05 PM

atul edited reviewers, added: rohan; removed: marcin.Feb 1 2023, 9:19 AM

ashoat accepted this revision.Feb 1 2023, 10:36 AM

This revision is now accepted and ready to land.Feb 1 2023, 10:36 AM

rebase + land

This revision was landed with ongoing or failed builds.Feb 1 2023, 11:18 AM

Closed by commit rCOMM3e9b71d2c1e0: [web] Pull `SIWEButton` out of `SIWE` component (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3e9b71d2c1e0: [web] Pull `SIWEButton` out of `SIWE` component.

Harbormaster completed remote builds in B15946: Diff 21772.Feb 1 2023, 11:34 AM

Revision Contents
Changeset List

Path

Size

web/

account/

siwe-button.react.js

36 lines

siwe.react.js

22 lines

Diff 21772

View Options

web/account/siwe-button.react.js