Page MenuHomePhabricator

[keyserver] Fix publishing new messages / latest messages when a new message is created.
ClosedPublic

Authored by tomek on Feb 2 2023, 8:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 3:57 PM
Unknown Object (File)
Apr 17 2024, 1:03 PM
Unknown Object (File)
Apr 17 2024, 1:03 PM
Unknown Object (File)
Apr 17 2024, 1:03 PM
Unknown Object (File)
Apr 17 2024, 12:52 PM
Unknown Object (File)
Mar 21 2024, 10:08 AM
Unknown Object (File)
Mar 20 2024, 5:41 AM
Unknown Object (File)
Mar 20 2024, 5:41 AM
Subscribers

Details

Summary

In D6224 we've introduced a bug that causes new messages to not always be delivered to some users. The issue is described in https://linear.app/comm/issue/ENG-2889/threads-arent-marked-as-unread-on-web.

This solution modifies the logic so that we only skip the part responsible for notifications when device list is empty.

Test Plan

Open two web clients with different users logged in. Make it so one of them doesn't have device id set in any of the cookies. Check if before this diff only one user receives new messages / thread unread status updates. Check if after this diff both users receive these.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

keyserver/src/creators/message-creator.js
431 ↗(On Diff #21864)

We had to change that so that it doesn't shadow the other variable.

ashoat published this revision for review.Feb 2 2023, 9:06 AM
ashoat accepted this revision.
This revision is now accepted and ready to land.Feb 2 2023, 9:06 AM