Page MenuHomePhabricator

[services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate function
ClosedPublic

Authored by max on Feb 6 2023, 4:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 9:19 PM
Unknown Object (File)
Sun, Apr 21, 9:19 PM
Unknown Object (File)
Sun, Apr 21, 9:19 PM
Unknown Object (File)
Sun, Apr 21, 9:18 PM
Unknown Object (File)
Sun, Apr 21, 9:15 PM
Unknown Object (File)
Mar 21 2024, 7:42 AM
Unknown Object (File)
Mar 21 2024, 7:42 AM
Unknown Object (File)
Mar 21 2024, 7:42 AM
Subscribers

Details

Summary

This diff introduces extracting the deleteQueueIfEmpty calling for the DeliveryBroker into a separate function to call it in the following D6626 from the Rust gRPC handler.
The reason for extracting is disabling messages persisting in the DynamoDB database by the config flag introduced in the D6622. In the following D6626, we will call deleteQueueIfEmpty function, but skip to remove the messages from the database if the config flag from D6622 is presented.

Linear task: ENG-2641

Test Plan
  1. CI gates are passed.
  2. Manual testing should be performed on the following D6626 diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max added a reviewer: bartek.
max published this revision for review.Feb 6 2023, 5:46 AM
This revision is now accepted and ready to land.Feb 7 2023, 9:02 AM

Rebasing on master and parent changes.