Page MenuHomePhabricator

[services] Tunnelbroker - Disabling messages persistence on messages removing
ClosedPublic

Authored by max on Feb 6 2023, 5:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 4:55 PM
Unknown Object (File)
Tue, Nov 19, 12:51 AM
Unknown Object (File)
Tue, Nov 19, 12:51 AM
Unknown Object (File)
Nov 15 2024, 11:43 PM
Unknown Object (File)
Nov 12 2024, 8:55 AM
Unknown Object (File)
Oct 26 2024, 9:55 PM
Unknown Object (File)
Oct 17 2024, 9:39 AM
Unknown Object (File)
Oct 12 2024, 10:42 PM
Subscribers

Details

Summary

This diff introduces changes to the Rust gRPC messages stream handler to disable removing messages from the DynamoDB database when the config flag from the D6622 is presented. The reason to skip messages removal is the ENG-2641 task where we are skipping the persistence of the message in the database in the case when the config flag is presented.

Linear task: ENG-2641

Test Plan
  1. Passing the CI gates.
  2. Manual testing: Connect to the gRPC messages stream and send the message to the certain deviceID. Connect to the stream as a client on this deviceID to which the message was sent. Consume the message. The expected result is that the message will not be persisted in the DynamoDB messages table and there is no error when trying to remove the message on consuming.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.
max published this revision for review.Feb 6 2023, 5:45 AM
max edited the summary of this revision. (Show Details)
max edited the test plan for this revision. (Show Details)
max added a reviewer: bartek.
This revision is now accepted and ready to land.Feb 13 2023, 5:07 PM

Rebasing on master and parent changes.