Page MenuHomePhabricator

[web] Add All communities / Inbox button
ClosedPublic

Authored by inka on Feb 8 2023, 3:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 19, 4:18 AM
Unknown Object (File)
Mon, Feb 19, 4:18 AM
Unknown Object (File)
Mon, Feb 19, 4:18 AM
Unknown Object (File)
Mon, Feb 19, 4:18 AM
Unknown Object (File)
Mon, Feb 19, 4:18 AM
Unknown Object (File)
Sun, Feb 18, 5:05 PM
Unknown Object (File)
Sun, Feb 18, 3:25 PM
Unknown Object (File)
Sun, Feb 18, 2:58 PM
Subscribers

Details

Summary

Issue: https://linear.app/comm/issue/ENG-2887/create-all-communities-button
As discussed in ENG-1882 we want to have a "All communities" button, that resets the calendar filters to show all chats the user is a member of. This is in contrast to ENG-2794, where we create the
possibility to display in filters panel only chats from a given community.
The styles will be revisited during https://linear.app/comm/issue/ENG-2671/style-community-drawer-on-web

Test Plan

Run web app, check that at the top of the drawer:

  1. in calendar tab there is a "All communities" button, and pressing it resets the community filter
  2. in all other tabs there is a "Inbox" button, and pressing it navigates back to chat tab

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Feb 8 2023, 3:32 AM
This revision is now accepted and ready to land.Feb 8 2023, 7:34 AM
web/sidebar/community-picker.react.js
36 ↗(On Diff #22267)

Actually after looking at it more, maybe it would be better to do something like

const isCalendarOpen = useSelector(state => state.navInfo.tab === 'calendar');

like we do in isSettingsOpen and isInboxOpen