Page MenuHomePhabricator

[native] Fixing wrong leftBorderColor on the quotes
ClosedPublic

Authored by kuba on Feb 9 2023, 2:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 2:45 PM
Unknown Object (File)
Fri, Nov 22, 11:49 PM
Unknown Object (File)
Nov 16 2024, 9:37 PM
Unknown Object (File)
Nov 16 2024, 9:37 PM
Unknown Object (File)
Nov 16 2024, 9:37 PM
Unknown Object (File)
Oct 29 2024, 1:33 PM
Unknown Object (File)
Oct 29 2024, 1:33 PM
Unknown Object (File)
Oct 29 2024, 1:32 PM
Subscribers

Details

Summary

Android interprets borderColors differently from iOS. On iOS borders are on top of the body of the component, and on Android, borders are next to it.

Test Plan

Checking new behavior with different colors and themes, on both operations systems.

Result (Android on the left):

Screenshot 2023-02-09 at 12.11.37.png (1×1 px, 829 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kuba edited the test plan for this revision. (Show Details)

Can we make this look exactly like iOS? Please share screenshots of iOS in the Test Plan. I think a border is still missing

(Feel free to handle this in a separate task if you prefer)

ashoat added a subscriber: rohan.

Adding @rohan, who has some context on Markdown

Can we make this look exactly like iOS? Please share screenshots of iOS in the Test Plan. I think a border is still missing

(Feel free to handle this in a separate task if you prefer)

I am not sure what you mean by looking exactly like iOS. The current version looks like this:

Screenshot_1676017844.png (2×1 px, 170 KB)

I will remove from Test Plan screen that was made before the changes.

kuba edited the test plan for this revision. (Show Details)
tomek added a reviewer: ashoat.

On both platforms all the borders are present (according to the test plan). The only difference is that all the colors on iOS look less saturated, but if we really want to address that, we should do it as a separate task.

You're right! I was thinking of web, which I think looks a little better:

Screenshot 2023-02-12 at 9.01.52 AM.png (270×318 px, 17 KB)

(I agree that making native look like this is out-of-scope here)

This revision is now accepted and ready to land.Feb 12 2023, 6:02 AM