[Nix Docs] Copy phabricator account creation section
ClosedPublic
Actions

Authored by • jon on Feb 13 2023, 4:56 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMMa46b88565a7d: [Nix Docs] Copy phabricator account creation section

Summary

Was able to find the related header for all other sections, only
initial Phabricator account creation was missing.

This is just a straight copy of https://github.com/CommE2E/comm/blob/abe832b337bc320952e6bfd029e623736b6075c9/docs/dev_environment.md#phabricator. Edits to the section will be in the following diff to make review easier.

https://linear.app/comm/issue/ENG-3001

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Feb 13 2023, 4:56 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 13 2023, 4:56 PM

• jon added a child revision: D6726: [Nix Docs] Edit Phabricator account section for continuity.Feb 13 2023, 4:57 PM

• jon added a child revision: D6727: [Docs] Point to Nix docs as default developer documentation.Feb 13 2023, 5:01 PM

Harbormaster completed remote builds in B16466: Diff 22512.Feb 13 2023, 5:11 PM

• jon requested review of this revision.Feb 13 2023, 5:11 PM

it's unclear to me what we mean by "shared workflows." can we use different terminology?

docs/nix_shared_workflows.md
37 ↗	(On Diff #22512)
39 ↗	(On Diff #22512)

This revision now requires changes to proceed.Feb 13 2023, 6:22 PM

@ashoat asked me to just initially copy the existing documentation when applicable (this diff), then reword as necessary in another diff ( D6726 in this case).

• jon marked 2 inline comments as done.Feb 14 2023, 8:39 AM

• jon removed a child revision: D6727: [Docs] Point to Nix docs as default developer documentation.

• jon added a child revision: D6727: [Docs] Point to Nix docs as default developer documentation.Feb 14 2023, 8:42 AM

• jon removed a child revision: D6727: [Docs] Point to Nix docs as default developer documentation.Feb 14 2023, 8:42 AM

I don't really understand why we can't just make the copy changes here. Sounds like you and @ashoat discussed this so he should take a look

it's unclear to me what we mean by "shared workflows." can we use different terminology?

Bumping this question

varun mentioned this in D6726: [Nix Docs] Edit Phabricator account section for continuity.Feb 14 2023, 10:52 AM

I don't really understand why we can't just make the copy changes here. Sounds like you and @ashoat discussed this so he should take a look

@jon is probably referring to this

I think @varun's inline suggestions are good ones, and we should apply in D6726.

As for "shared workflows"... I agree it might be a little ambiguous, but I'm not sure what a better term would be, and am hoping it won't be so confusing since people will get to it from the mainline nix_dev_env.md, which it's contrasted against "Web workflows" and "Shared workflows".

This revision is now accepted and ready to land.Feb 15 2023, 7:21 AM

As for "shared workflows"... I agree it might be a little ambiguous, but I'm not sure what a better term would be, and am hoping it won't be so confusing since people will get to it from the mainline

I change it to "Other workflows", "Useful Workflows", separate the tableplus into a different section altogether and add a "Contributing workflows", or something similar. I don't have a strong preference. I would like to avoid just a single list of everything through.

I think "Shared Workflows" is a better term than either "Other Workflows" or "Useful Workflows". Probably best to leave it as-is unless @varun has a better suggestion

In D6725#200903, @ashoat wrote:

I think "Shared Workflows" is a better term than either "Other Workflows" or "Useful Workflows". Probably best to leave it as-is unless @varun has a better suggestion

shared workflows makes sense when contrasted with web/native workflows. i was just missing that context

Closed by commit rCOMMa46b88565a7d: [Nix Docs] Copy phabricator account creation section (authored by • jon). · Explain WhyFeb 17 2023, 11:42 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMa46b88565a7d: [Nix Docs] Copy phabricator account creation section.