[Nix Docs] Edit Phabricator account section for continuity
ClosedPublic
Actions

Authored by • jon on Feb 14 2023, 12:57 AM.

Details

Reviewers

ashoat
varun

Commits

rCOMM1815215602e1: [Nix Docs] Edit Phabricator account section for continuity

Summary

Modify wording to fit better in the new context.

Depends on D6725

Test Plan

N/A

Rendered: https://github.com/CommE2E/comm/blob/jonringer/nix-docs-supercede/docs/nix_dev_env.md

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Feb 14 2023, 12:57 AM

Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 14 2023, 12:57 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 14 2023, 6:58 AM

Harbormaster failed remote builds in B16467: Diff 22513!

• jon mentioned this in D6725: [Nix Docs] Copy phabricator account creation section.Feb 14 2023, 4:38 PM

• jon added a child revision: D6727: [Docs] Point to Nix docs as default developer documentation.

Harbormaster completed remote builds in B16467: Diff 22513.Feb 14 2023, 4:43 PM

• jon requested review of this revision.Feb 14 2023, 4:43 PM

Left some suggested edits on D6725, would be great to apply them here

This revision now requires changes to proceed.Feb 14 2023, 6:52 PM

Apply feedback from D6725

Update TOC

• jon edited the test plan for this revision. (Show Details)Feb 16 2023, 4:44 PM

Harbormaster failed remote builds in B16560: Diff 22656!Feb 16 2023, 4:46 PM

Harbormaster failed remote builds in B16561: Diff 22657!

Harbormaster completed remote builds in B16561: Diff 22657.Feb 16 2023, 7:21 PM

varun accepted this revision.Feb 16 2023, 9:35 PM

This revision is now accepted and ready to land.Feb 16 2023, 9:35 PM

ashoat accepted this revision.Feb 17 2023, 6:15 PM

Closed by commit rCOMM1815215602e1: [Nix Docs] Edit Phabricator account section for continuity. · Explain WhyFeb 17 2023, 7:42 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM1815215602e1: [Nix Docs] Edit Phabricator account section for continuity.

Revision Contents
Changeset List

Path

Size

docs/

nix_dev_env.md

1 line

nix_shared_workflows.md

4 lines

Diff 22690

View Options

docs/nix_dev_env.md