Issue: ENG-2476
Android: In some modals app buttons are rendered outside SaveArea and covered by the system GUI, especially in landscape mode.
Images:
Details
Details
Tested new view on Android and iOS modals:
- CameraModal (including staging view),
- VideoPlaybackModal,
- ImageModal.
Images:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/media/camera-modal.react.js | ||
|---|---|---|
| 619 ↗ | (On Diff #22552) | Is this View necessary? Since it has the same style as the parent, that is just flex: 1, it seems like it doesn't do much? I tried without it (on android), and it seemed to work |
| native/media/camera-modal.react.js | ||
|---|---|---|
| 619 ↗ | (On Diff #22552) | I believe that it is. If you remove this View and rotate the phone to landscape mode you end up with X going outside the SaveAreaView.
Attaching screens:  With inner View:  |
| native/media/camera-modal.react.js | ||
|---|---|---|
| 619 ↗ | (On Diff #22552) | It's surprising that we need it. I guess it might be related to the fact that the buttons are absolutely positioned. |
| 647 ↗ | (On Diff #22552) | Do we have to provide both flex: 1 and stagingViewOverlay styles? Is flex: 1 really useful? It works in one direction, so the behavior might be different when a phone is rotated. |
| native/media/camera-modal.react.js | ||
|---|---|---|
| 619 ↗ | (On Diff #22552) | Okay, thank you for the screenshots. |
| native/media/camera-modal.react.js | ||
|---|---|---|
| 647 ↗ | (On Diff #22552) | I checked it and you are right. Everything works correctly without flex: 1 style. I removed it and updated the diff. |