Details
- Reviewers
michal kuba kamil - Commits
- rCOMM364a478dbfdb: [web] Change the Apps tab to be a + button
Run web app, checked that the button displays correctly, and pressing it navigates to Apps screen
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Two things:
- I think we need some kind of indicator (like a purple bottom border for Chat/Calendars buttons), seems really confusing to me from the user's perspective that there is no difference between the selected and not selected apps tab. Hover also will be great.
- Look like it will happen soon, but what if there will be a lot of apps? Shouldn't + be sticked to the right side of the container, always visible, and all items scrollable (talking about situation when entire row is filled with apps)? Or at least all items with '+' button scrollable.
- I brought this up in the issue, will update the diff when I get an answer
- In the designs the "+" is at the end of tabs, so how's this:
Placing it at the end of tabs, but if there are too many, sticking it to the right side? (it's done with css, not with if's of course)
About the indicator: in the issues comments it has been decided that this button will open a modal instead of a page. For modals we don't have indicators
Still waiting for the answer about hover
About the indicator: in the issues comments it has been decided that this button will open a modal instead of a page. For modals we don't have indicators
Nice, the modal will be more natural
- In the designs the "+" is at the end of tabs, so how's this:
Placing it at the end of tabs, but if there are too many, sticking it to the right side? (it's done with css, not with if's of course)
Looks awesome to me
Add hover, make the plus button stick to the right edge when there are many apps. The concern about the button not being marked in any way when pressed will be addressed in future diffs, by
making the Apps tab be a modal