Page MenuHomePhabricator

[web] Change the Apps tab to be a + button
ClosedPublic

Authored by inka on Feb 14 2023, 6:27 AM.
Tags
None
Referenced Files
F1434105: D6733.diff
Thu, Mar 28, 8:23 AM
Unknown Object (File)
Mon, Mar 25, 1:58 PM
Unknown Object (File)
Mon, Mar 25, 1:58 PM
Unknown Object (File)
Mon, Mar 25, 1:57 PM
Unknown Object (File)
Mon, Mar 25, 1:57 PM
Unknown Object (File)
Mon, Mar 25, 1:57 PM
Unknown Object (File)
Mon, Mar 25, 1:57 PM
Unknown Object (File)
Mon, Mar 25, 1:57 PM
Subscribers

Details

Summary
Test Plan

Run web app, checked that the button displays correctly, and pressing it navigates to Apps screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Feb 14 2023, 6:42 AM
kamil requested changes to this revision.Feb 15 2023, 3:47 AM

Two things:

  1. I think we need some kind of indicator (like a purple bottom border for Chat/Calendars buttons), seems really confusing to me from the user's perspective that there is no difference between the selected and not selected apps tab. Hover also will be great.
  2. Look like it will happen soon, but what if there will be a lot of apps? Shouldn't + be sticked to the right side of the container, always visible, and all items scrollable (talking about situation when entire row is filled with apps)? Or at least all items with '+' button scrollable.
This revision now requires changes to proceed.Feb 15 2023, 3:47 AM
  1. I brought this up in the issue, will update the diff when I get an answer
  2. In the designs the "+" is at the end of tabs, so how's this:


Placing it at the end of tabs, but if there are too many, sticking it to the right side? (it's done with css, not with if's of course)

About the indicator: in the issues comments it has been decided that this button will open a modal instead of a page. For modals we don't have indicators

Still waiting for the answer about hover

About the indicator: in the issues comments it has been decided that this button will open a modal instead of a page. For modals we don't have indicators

Nice, the modal will be more natural

  1. In the designs the "+" is at the end of tabs, so how's this:


Placing it at the end of tabs, but if there are too many, sticking it to the right side? (it's done with css, not with if's of course)

Looks awesome to me

Add hover, make the plus button stick to the right edge when there are many apps. The concern about the button not being marked in any way when pressed will be addressed in future diffs, by
making the Apps tab be a modal

Please rebase on master to fix iOS build

This revision is now accepted and ready to land.Feb 22 2023, 1:57 AM
inka planned changes to this revision.Feb 22 2023, 9:50 AM

@kamil pointed out, that this probably should be a <button>, not <a>

This revision is now accepted and ready to land.Feb 23 2023, 12:25 AM
web/navigation-panels/topbar.react.js
17 ↗(On Diff #22959)

It's no longer HTMLAnchorElement, maybe HTMLButtonElement?

18 ↗(On Diff #22959)

do we still need this?