Page MenuHomePhabricator

[services] Tunnelbroker - Adding boolean config parameters to be used in the config file
ClosedPublic

Authored by max on Feb 16 2023, 7:18 AM.
Tags
None
Referenced Files
F3485321: D6749.id22863.diff
Tue, Dec 17, 7:55 PM
F3485320: D6749.id22655.diff
Tue, Dec 17, 7:55 PM
F3485297: D6749.id.diff
Tue, Dec 17, 7:54 PM
F3485277: D6749.diff
Tue, Dec 17, 7:52 PM
Unknown Object (File)
Mon, Dec 16, 1:59 AM
Unknown Object (File)
Wed, Dec 11, 2:41 AM
Unknown Object (File)
Wed, Nov 20, 1:16 PM
Unknown Object (File)
Wed, Nov 20, 12:00 PM
Subscribers

Details

Summary

This diff introduces changes that add the ability to use boolean config parameters be used in the config ini file. By default, it is used as a CLI parameter in the case of the boolean.
By adding the boolean type and default value we can use boolean parameters in the config ini file by providing them in appropriate sections.

Linear task: ENG-3022

Test Plan

Adding parameters to the config file:

[sessions]
skip_authentication = true
disable_deviceid_validation = true

resulting in a true on calling isConfigParameterSet

Diff Detail

Repository
rCOMM Comm
Branch
fix-config-bools
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max held this revision as a draft.
max published this revision for review.Feb 16 2023, 7:28 AM
max retitled this revision from [services] Tunnelbroker - Fixing boolean config parameters to be used in the config file to [services] Tunnelbroker - Adding boolean config parameters to be used in the config file.
max edited the summary of this revision. (Show Details)
max edited the test plan for this revision. (Show Details)
max added a reviewer: bartek.
This revision is now accepted and ready to land.Feb 20 2023, 3:57 AM