Page MenuHomePhabricator

[web] Restyle search area in FilterPanel
ClosedPublic

Authored by inka on Feb 17 2023, 2:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 22, 1:53 PM
Unknown Object (File)
Thu, Feb 22, 1:40 PM
Unknown Object (File)
Thu, Feb 22, 1:18 PM
Unknown Object (File)
Thu, Feb 22, 12:20 PM
Unknown Object (File)
Thu, Feb 22, 10:46 AM
Unknown Object (File)
Thu, Feb 22, 10:46 AM
Unknown Object (File)
Thu, Feb 22, 10:02 AM
Unknown Object (File)
Thu, Feb 22, 8:45 AM
Subscribers

Details

Summary

Issue: https://linear.app/comm/issue/ENG-3014/add-a-button-to-close-the-filter-panel
There is supposed to be a button for closing the filter panel, inside of the filter panel. Additionally some styles around it were changed, so I changed them as well to keep the panel looking consistent. Note that in the issues comments it had been decided to keep the search bars background colour consistent with the rest of the app for now.
The filters buttnon (the one used for opening) is supposed to disappear when the panel is open

image.png (358×568 px, 26 KB)

Test Plan

run web app, checked that items in the filter panel display correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Make the button close the panel - it turned out it required very little changes, so amending to this diff

inka edited the summary of this revision. (Show Details)
inka requested review of this revision.Feb 17 2023, 2:41 AM

Apply new prettier rules

web/calendar/filter-panel.css
9–10 ↗(On Diff #22934)

Will fix this

133–134 ↗(On Diff #22934)

Will fix this

Use values from typography.css

michal added inline comments.
web/calendar/calendar.react.js
167 ↗(On Diff #22995)

Instead of changing the style, can we conditionally render the filter button?

This revision is now accepted and ready to land.Mar 2 2023, 3:00 AM