Page MenuHomePhabricator
Differential D6787

[Nix] Enable localstack
ClosedPublic
Actions

Authored by • jon on Feb 20 2023, 1:29 PM.
Tags
None
Referenced Files
F3499632: D6787.diff
Thu, Dec 19, 11:42 PM
Unknown Object (File)
Sun, Dec 8, 5:34 AM
Unknown Object (File)
Nov 1 2024, 7:13 AM
Unknown Object (File)
Oct 28 2024, 10:37 AM
Unknown Object (File)
Oct 27 2024, 5:34 PM
Unknown Object (File)
Oct 27 2024, 5:34 PM
Unknown Object (File)
Oct 27 2024, 5:34 PM
Unknown Object (File)
Oct 27 2024, 5:33 PM
View All Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
bartek
varun
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMb185e613b75b: [Nix] Enable localstack
Summary

Make localstack the default target when interacting with
AWS in the nix development environment.

Test Plan
which localstack # points to nix store

This gets tested more thoroughly in a later diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Feb 20 2023, 1:29 PM
Owners added a reviewer: Restricted Owners Package.Feb 20 2023, 1:29 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 20 2023, 1:29 PM
• jon added a child revision: D6788: [Identity] Add deleteUser RPC to proto files.Feb 20 2023, 1:34 PM
Harbormaster completed remote builds in B16638: Diff 22749.Feb 20 2023, 1:44 PM
• jon requested review of this revision.Feb 20 2023, 1:44 PM
varun accepted this revision.Feb 20 2023, 6:09 PM
This revision is now accepted and ready to land.Feb 20 2023, 6:09 PM
ashoat added inline comments.Feb 20 2023, 7:03 PM
nix/dev-shell.nix
79 ↗(On Diff #22749)

Did this get resolved?

• jon marked an inline comment as done.Feb 21 2023, 1:23 PM
• jon added inline comments.
nix/dev-shell.nix
79 ↗(On Diff #22749)

In https://phab.comm.dev/D6107 it was resolved, which enabled the comm-dev services start to include localstack.

• jon updated this revision to Diff 22893.Feb 21 2023, 1:36 PM
• jon marked an inline comment as done.

Rebase on master

bartek accepted this revision.Feb 21 2023, 1:41 PM
Harbormaster completed remote builds in B16736: Diff 22893.Feb 21 2023, 1:52 PM
Closed by commit rCOMMb185e613b75b: [Nix] Enable localstack (authored by • jon). · Explain WhyFeb 22 2023, 4:20 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMb185e613b75b: [Nix] Enable localstack.

Revision Contents
Changeset List

PathSize
nix/
4 lines
scripts/
3 lines

Diff 22952

View Options

nix/dev-shell.nix

Loading...
View Options

scripts/source_development_defaults.sh

Loading...