[keyserver] Removing `.gitignore` from rust-node-addon
ClosedPublic
Actions

Authored by • max on Feb 20 2023, 3:52 PM.

Details

Reviewers

varun
• jon
tomek
ashoat

Commits

rCOMMf1bc99677895: [keyserver] Removing `.gitignore` from rust-node-addon

Summary

This diff removes .gitignore file from the rust-node-addon and adds ignoring directories to the global .gitignore file at the root of the project. It makes sense to use a root gitignore file to ignore these two directories.

Linear task: ENG-3048

Test Plan

Running yarn clieaninstall will build the rust-node-addon as a dependency. The building process produces files in the target and napi subdirectories which are ignored.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Feb 20 2023, 3:52 PM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 20 2023, 3:52 PM

• max published this revision for review.Feb 20 2023, 3:57 PM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, • jon, tomek.

• max added a parent revision: D6791: [keyserver] Removing from the rust-node-addon gitignore and populate it.

• max retitled this revision from [keyserver] Removing in rust-node-addon to [keyserver] Removing `.gitignore` in rust-node-addon.

Harbormaster completed remote builds in B16649: Diff 22776.Feb 20 2023, 4:07 PM

• jon accepted this revision.Feb 20 2023, 6:08 PM

i actually prefer having separate .gitignore files at the cargo project level but it’s not a strong opinion. just think it makes the files more readable. also we already have other .gitignore files in the repo I think

This revision is now accepted and ready to land.Feb 20 2023, 8:50 PM

In D6792#202240, @varun wrote:

i actually prefer having separate .gitignore files at the cargo project level but it’s not a strong opinion. just think it makes the files more readable. also we already have other .gitignore files in the repo I think

I'm not insisting to remove this gitignore as well, but from my perspective, we should use the project root and second-level (keyserver's) gitignoring as preferred. cc to @ashoat for a final decision.

• max added a reviewer: ashoat.Feb 21 2023, 5:52 AM

This revision now requires review to proceed.Feb 21 2023, 5:52 AM

• max retitled this revision from [keyserver] Removing `.gitignore` in rust-node-addon to [keyserver] Removing `.gitignore` from rust-node-addon.Feb 21 2023, 6:08 AM

• max edited the summary of this revision. (Show Details)

I don't have an opinion

This revision is now accepted and ready to land.Feb 21 2023, 6:18 AM

Closed by commit rCOMMf1bc99677895: [keyserver] Removing `.gitignore` from rust-node-addon (authored by • max). · Explain WhyFeb 21 2023, 6:46 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMf1bc99677895: [keyserver] Removing `.gitignore` from rust-node-addon.