Paths

Table of Contentst

-
keyserver/addons/rust-node-addon/
-
addons/
-
rust-node-addon/
-
.gitignore
-
Cargo.lock

[keyserver] Removing from the rust-node-addon gitignore and populate it
ClosedPublic
Actions

Authored by • max on Feb 20 2023, 3:40 PM.

Details

Reviewers

ginsu
varun
• jon
ashoat

Commits

rCOMM91f0d931ada5: [keyserver] Removing from the rust-node-addon gitignore and populate it

Summary

This diff removes Cargo.lock file from the .gitignore in the rust-node-addon and populates this file. We should add a lock file to lock the dependencies versions and avoid possible errors due to the versions inconsistency.

Linear task: ENG-3048

Test Plan

Running yarn cleaninstall from the root of the project results in a successful build of the rust-node-addon library as a part of the dependencies.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Feb 20 2023, 3:40 PM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 20 2023, 3:40 PM

• max edited the summary of this revision. (Show Details)Feb 20 2023, 3:46 PM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: ginsu, varun, • jon.

• max published this revision for review.Feb 20 2023, 3:52 PM

Harbormaster completed remote builds in B16648: Diff 22775.Feb 20 2023, 3:56 PM

• max added a child revision: D6792: [keyserver] Removing `.gitignore` from rust-node-addon.Feb 20 2023, 3:58 PM

ashoat accepted this revision.Feb 20 2023, 6:03 PM

This revision is now accepted and ready to land.Feb 20 2023, 6:03 PM

Closed by commit rCOMM91f0d931ada5: [keyserver] Removing from the rust-node-addon gitignore and populate it (authored by • max). · Explain WhyFeb 21 2023, 5:48 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM91f0d931ada5: [keyserver] Removing from the rust-node-addon gitignore and populate it.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

.gitignore

1 line

Cargo.lock

Diff 22829

View Options

keyserver/addons/rust-node-addon/.gitignore

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines	<View {...viewProps}>
<View onLayout={onLayout} ref={viewRef}>		<View onLayout={onLayout} ref={viewRef}>
<AnimatedView style={{ opacity: contentAndHeaderOpacity }}>		<AnimatedView style={{ opacity: contentAndHeaderOpacity }}>
<InnerRobotextMessage		<InnerRobotextMessage
item={item}		item={item}
onPress={onPress}		onPress={onPress}
onLongPress={onLongPress}		onLongPress={onLongPress}
/>		/>
</AnimatedView>		</AnimatedView>
{inlineSidebar}
</View>		</View>
		{inlineSidebar}
</View>		</View>
);		);
}		}

const unboundStyles = {		const unboundStyles = {
sidebar: {		sidebar: {
marginTop: -5,		marginTop: -5,
marginBottom: 5,		marginBottom: 5,
},		},
};		};

export { RobotextMessage };		export { RobotextMessage };