Page MenuHomePhabricator
Differential D6791

[keyserver] Removing from the rust-node-addon gitignore and populate it
ClosedPublic
Actions

Authored by • max on Feb 20 2023, 3:40 PM.
Tags
None
Referenced Files
F5313428: D6791.id22829.diff
Tue, Apr 8, 1:06 PM
F5313427: D6791.id.diff
Tue, Apr 8, 1:06 PM
F5313426: D6791.diff
Tue, Apr 8, 1:06 PM
Unknown Object (File)
Sun, Apr 6, 6:58 AM
Unknown Object (File)
Fri, Apr 4, 4:51 PM
Unknown Object (File)
Fri, Apr 4, 4:51 PM
Unknown Object (File)
Fri, Apr 4, 4:51 PM
Unknown Object (File)
Wed, Apr 2, 3:01 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ginsu
varun
• jon
ashoat
Commits
rCOMM91f0d931ada5: [keyserver] Removing from the rust-node-addon gitignore and populate it
Summary

This diff removes Cargo.lock file from the .gitignore in the rust-node-addon and populates this file. We should add a lock file to lock the dependencies versions and avoid possible errors due to the versions inconsistency.

Linear task: ENG-3048

Test Plan

Running yarn cleaninstall from the root of the project results in a successful build of the rust-node-addon library as a part of the dependencies.

Diff Detail

Repository
rCOMM Comm
Branch
add-cargo-lock
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
1 line

Diff 22775

View Options

keyserver/addons/rust-node-addon/.gitignore

Show First 20 Lines • Show All 143 Lines • ▼ Show 20 Linesfunction validNavState(state: PossiblyStaleNavigationState): boolean {
} }
const [firstRoute] = state.routes; const [firstRoute] = state.routes;
if (firstRoute.name !== AppRouteName) { if (firstRoute.name !== AppRouteName) {
return false; return false;
} }
return true; return true;
} }
function getChildRouteFromNavigatorRoute(
parentRoute: PossiblyStaleRoute<>,
childRouteName: string,
): PossiblyStaleRoute<> {
const parentState = getStateFromNavigatorRoute(parentRoute);
const childRoute = parentState.routes.find(
route => route.name === childRouteName,
);
invariant(
childRoute,
`parentRoute should contain route for ${childRouteName}`,
);
return childRoute;
}
export { export {
getStateFromNavigatorRoute, getStateFromNavigatorRoute,
getThreadIDFromParams, getThreadIDFromParams,
getThreadIDFromRoute, getThreadIDFromRoute,
currentLeafRoute, currentLeafRoute,
findRouteIndexWithKey, findRouteIndexWithKey,
removeScreensFromStack, removeScreensFromStack,
validNavState, validNavState,
getChildRouteFromNavigatorRoute,
}; };
View Options

keyserver/addons/rust-node-addon/Cargo.lock

Show First 20 Lines • Show All 143 Lines • ▼ Show 20 Linesfunction validNavState(state: PossiblyStaleNavigationState): boolean {
} }
const [firstRoute] = state.routes; const [firstRoute] = state.routes;
if (firstRoute.name !== AppRouteName) { if (firstRoute.name !== AppRouteName) {
return false; return false;
} }
return true; return true;
} }
function getChildRouteFromNavigatorRoute(
parentRoute: PossiblyStaleRoute<>,
childRouteName: string,
): PossiblyStaleRoute<> {
const parentState = getStateFromNavigatorRoute(parentRoute);
const childRoute = parentState.routes.find(
route => route.name === childRouteName,
);
invariant(
childRoute,
`parentRoute should contain route for ${childRouteName}`,
);
return childRoute;
}
export { export {
getStateFromNavigatorRoute, getStateFromNavigatorRoute,
getThreadIDFromParams, getThreadIDFromParams,
getThreadIDFromRoute, getThreadIDFromRoute,
currentLeafRoute, currentLeafRoute,
findRouteIndexWithKey, findRouteIndexWithKey,
removeScreensFromStack, removeScreensFromStack,
validNavState, validNavState,
getChildRouteFromNavigatorRoute,
}; };