[web] Add hook for creating push subscription
ClosedPublic
Actions

Authored by michal on Feb 21 2023, 9:24 AM.

Details

Reviewers

atul
tomek
inka
ashoat

Commits

rCOMMa8c642f13679: [web] Add hook for creating push subscription

Summary

Add a hook that will return a function that creates a new push subscription. It will be used in the later diffs.

Test Plan

Tested with the later diffs: check that the subscription is correctly created and saved in the keyserver db and web redux

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Feb 21 2023, 9:24 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 21 2023, 9:24 AM

michal added a parent revision: D6818: [web] Register service worker for notifs.Feb 21 2023, 9:26 AM

michal added a child revision: D6820: [web] Add notification permission modal.Feb 21 2023, 9:29 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 21 2023, 9:38 AM

Harbormaster failed remote builds in B16715: Diff 22869!

Rebase

Harbormaster completed remote builds in B16760: Diff 22921.Feb 22 2023, 2:06 AM

michal requested review of this revision.Feb 22 2023, 2:06 AM

ashoat accepted this revision.Feb 22 2023, 11:17 AM

This revision is now accepted and ready to land.Feb 22 2023, 11:17 AM

Closed by commit rCOMMa8c642f13679: [web] Add hook for creating push subscription (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMar 1 2023, 12:51 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMa8c642f13679: [web] Add hook for creating push subscription.

Revision Contents
Changeset List

Path

Size

web/

push-notif/

push-notifs-handler.js

40 lines

Diff 23290

View Options

web/push-notif/push-notifs-handler.js

[web] Add hook for creating push subscriptionClosedPublicActions