Page MenuHomePhabricator

[web] Link modal in the thread menu
ClosedPublic

Authored by rohan on Feb 23 2023, 10:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 5:17 PM
Unknown Object (File)
Mon, Nov 11, 5:07 PM
Unknown Object (File)
Thu, Nov 7, 11:38 PM
Unknown Object (File)
Thu, Nov 7, 11:38 PM
Unknown Object (File)
Thu, Nov 7, 11:38 PM
Unknown Object (File)
Thu, Nov 7, 11:38 PM
Unknown Object (File)
Thu, Nov 7, 11:38 PM
Unknown Object (File)
Thu, Nov 7, 7:31 PM
Subscribers

Details

Summary

The thread menu should allow the user to open up the media gallery.

Linear: https://linear.app/comm/issue/ENG-2879/link-modal-in-the-thread-menu

Depends on D6863

Test Plan

Confirmed that the menu appears and pushes the modal on screen

Screenshot 2023-02-23 at 1.11.13 PM.png (1×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2023, 10:19 AM
Harbormaster failed remote builds in B16842: Diff 23021!
rohan added inline comments.
web/chat/thread-menu.react.js
88–90 ↗(On Diff #23021)

Removing this, forgot to update this on the web stack

Remove canViewThreadMediaGallery

web/chat/thread-menu.react.js
101–102 ↗(On Diff #23023)

Don't need return keyword or curly braces

This revision is now accepted and ready to land.Feb 26 2023, 7:52 AM
This revision was automatically updated to reflect the committed changes.