This diff handles actually displaying the media gallery component from the previous diff into the thread settings on native.
https://linear.app/comm/issue/ENG-2869/render-the-media-gallery-in-the-thread-settings-on-native
Depends on D6466
Differential D6467
[native] Render the media gallery in the thread settings on native rohan on Jan 30 2023, 8:46 AM. Authored by Tags None Referenced Files
Subscribers
Details This diff handles actually displaying the media gallery component from the previous diff into the thread settings on native. https://linear.app/comm/issue/ENG-2869/render-the-media-gallery-in-the-thread-settings-on-native Depends on D6466 As mentioned in the previous diff, I've hard coded some images into the component to check how the component renders with images. Displayed below is the screenshot.
Diff Detail
Event TimelineComment Actions
Personally think two rows of most recent media + a "see more" sort of button would make sense Comment Actions Agreed, that seems to also be inline with what Ted and I discussed this morning for native. This linear task tracks this, and I'll update it with more info once I hear back about the design confirmation https://linear.app/comm/issue/ENG-2876/display-three-media-initially-then-allow-user-to-see-more-on-native
Comment Actions Remove unnecessary check in thread settings. Tested to ensure the media gallery appears in the settings still. Comment Actions Passing back to you with question
Comment Actions Add a footer, visually it definitely makes sense to have and the padding seems better.
|