Page MenuHomePhabricator
Differential D6915

[native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth` requests
ClosedPublic
Actions

Authored by atul on Feb 28 2023, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 9:08 AM
Unknown Object (File)
Sun, Apr 28, 9:08 AM
Unknown Object (File)
Sun, Apr 28, 9:08 AM
Unknown Object (File)
Sun, Apr 28, 9:03 AM
Unknown Object (File)
Sun, Apr 28, 8:20 AM
Unknown Object (File)
Mar 28 2024, 5:01 PM
Unknown Object (File)
Mar 28 2024, 5:01 PM
Unknown Object (File)
Mar 28 2024, 5:01 PM
View All 67 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
varun
• jon
Commits
rCOMMf1886b95babb: [native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth`…
Summary

Modify nativeLogInExtraInfoSelector so it includes signedIdentityKeyBlob instead of primaryIdentityPublicKey.

Also some misc changes to remove old primaryIdentityPublicKey stuff and to allow signedIdentityKeyBlob in registerRequestInputValidator.

Next diff will include signedIdentityKeysBlob in createAccount and we should be good.

Depends on D6822

Test Plan

Successfully able to login, register, and SIWE. Set breakpoints and observed that signedIdentityKeysBlob was included in requests.

Login:

82d891.png (1×2 px, 464 KB)

e605e2.png (244×2 px, 77 KB)

Register:

e3b0bc.png (1×2 px, 624 KB)

SIWE:

6b2192.png (1×2 px, 576 KB)

b80b59.png (268×2 px, 94 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 28 2023, 7:46 PM
Harbormaster completed remote builds in B17016: Diff 23272.Feb 28 2023, 8:02 PM
atul requested review of this revision.Feb 28 2023, 8:02 PM
atul edited the test plan for this revision. (Show Details)Feb 28 2023, 8:04 PM
atul edited the test plan for this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)Feb 28 2023, 8:44 PM
atul added a child revision: D6916: [native][keyserver] Persist `signedIdentityKeysBlob` on `register` from `native`.Feb 28 2023, 8:56 PM
atul added a reviewer: varun.Mar 1 2023, 10:33 AM
atul added a reviewer: • jon.Mar 1 2023, 1:40 PM
varun accepted this revision.Mar 1 2023, 1:43 PM
This revision is now accepted and ready to land.Mar 1 2023, 1:43 PM
atul updated this revision to Diff 23344.Mar 1 2023, 2:18 PM

rebase before landing

Harbormaster completed remote builds in B17048: Diff 23344.Mar 1 2023, 2:34 PM
Closed by commit rCOMMf1886b95babb: [native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth`… (authored by atul). · Explain WhyMar 1 2023, 2:35 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMf1886b95babb: [native] Include `signedIdentityKeysBlob` in `login`/`register`/`siwe_auth`….

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
11 lines
lib/
types/
2 lines
native/
account/
3 lines
selectors/
12 lines
web/
account/
1 line

Diff 23345

View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

lib/types/account-types.js

Loading...
View Options

native/account/siwe-panel.react.js

Loading...
View Options

native/selectors/account-selectors.js

Loading...
View Options

web/account/traditional-login-form.react.js

Loading...