Differential D6999

[web] Fix compose subchannels modal for long names
ClosedPublic
Actions

Authored by inka on Mar 7 2023, 10:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 3, 1:38 PM

	Unknown Object (File)
	Thu, Apr 3, 1:38 PM

	Unknown Object (File)
	Thu, Apr 3, 1:38 PM

	Unknown Object (File)
	Fri, Mar 14, 7:03 PM

	Unknown Object (File)
	Thu, Mar 13, 9:04 AM

	Unknown Object (File)
	Feb 23 2025, 11:36 AM

	Unknown Object (File)
	Feb 21 2025, 1:20 AM

	Unknown Object (File)
	Jan 24 2025, 10:18 AM

Subscribers

Details

Reviewers

• kuba
michal
bartek

Commits

rCOMM45da19523557: [web] Fix compose subchannels modal for long names

Summary

issue: https://linear.app/comm/issue/ENG-3255/fix-compose-subchannel-modal-for-long-names

before:

Screenshot 2023-03-07 at 19.38.58.png (1×2 px, 211 KB)

after:

Screenshot 2023-03-07 at 19.42.45.png (1×2 px, 345 KB)

Test Plan

Run web app, opened compose subchannel modal for a chat with a very long name

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Mar 7 2023, 10:45 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 7 2023, 10:45 AM

inka edited the summary of this revision. (Show Details)Mar 7 2023, 10:46 AM

inka attached a referenced file: F416344: Screenshot 2023-03-07 at 19.42.45.png. (Show Details)

inka attached a referenced file: F416343: Screenshot 2023-03-07 at 19.38.58.png. (Show Details)

Harbormaster completed remote builds in B17176: Diff 23518.Mar 7 2023, 11:01 AM

inka requested review of this revision.Mar 7 2023, 11:01 AM

bartek accepted this revision.Mar 15 2023, 3:36 AM

This revision is now accepted and ready to land.Mar 15 2023, 3:36 AM

Closed by commit rCOMM45da19523557: [web] Fix compose subchannels modal for long names (authored by • InkaSokolowska). · Explain WhyMar 17 2023, 5:57 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM45da19523557: [web] Fix compose subchannels modal for long names.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

create/

compose-subchannel-modal.css

5 lines

compose-subchannel-modal.react.js

8 lines

Diff 23822

web/modals/threads/create/compose-subchannel-modal.css

	div.headerContainer {			div.loginContainer {
	flex: 1 1 auto;
	padding: 0 10px;
	}
	div.headerContents {
	display: flex;			display: flex;
	justify-content: space-between;			justify-content: center;
	align-items: center;
	padding-top: 5px;
	padding-bottom: 7px;
	}
	div.actionLinks > * {
	padding-right: 15px;
	color: white;
	font-weight: 300;
	}
	div.actionLinks > *:last-child {
	padding-right: 0;
	}
	header.header h1 {
	color: white;			color: white;
	font-size: 38px;
	}
	header.header {
	padding: 10px 20px;
	border-radius: 20px;
	border: 1px solid white;
	}			}

web/modals/threads/create/compose-subchannel-modal.react.js

	div.headerContainer {			div.loginContainer {
	flex: 1 1 auto;
	padding: 0 10px;
	}
	div.headerContents {
	display: flex;			display: flex;
	justify-content: space-between;			justify-content: center;
	align-items: center;
	padding-top: 5px;
	padding-bottom: 7px;
	}
	div.actionLinks > * {
	padding-right: 15px;
	color: white;
	font-weight: 300;
	}
	div.actionLinks > *:last-child {
	padding-right: 0;
	}
	header.header h1 {
	color: white;			color: white;
	font-size: 38px;
	}
	header.header {
	padding: 10px 20px;
	border-radius: 20px;
	border: 1px solid white;
	}			}