[native][AES] Implement encrypt function on Android
ClosedPublic
Actions

Authored by bartek on Mar 8 2023, 10:13 AM.

Details

Reviewers

marcin
atul
varun

Commits

rCOMMfc7383f60b2e: [native][AES] Implement encrypt function on Android

Summary

Counterpart of D7005 for Android. More context in that diff.

Docs: https://developer.android.com/reference/kotlin/javax/crypto/Cipher
Inspired by: https://levelup.gitconnected.com/doing-aes-gcm-in-android-adventures-in-the-field-72617401269d

Depends on D7006

Test Plan

The same as in D7005:

import * as AES from './utils/aes-crypto-module.js';

const key = AES.generateKey();
const plaintextBytes = new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
const ciphertext = AES.encrypt(key, plaintextBytes);
console.log('Ciphertext', ciphertext);
// ensured that ciphertext is 12+10+16=38 bytes long (ciphertext.length==38)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 8 2023, 10:13 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 8 2023, 10:13 AM

bartek added a child revision: D7008: [native][AES] Implement decrypt function on Android.Mar 8 2023, 10:15 AM

Harbormaster completed remote builds in B17191: Diff 23542.Mar 8 2023, 10:27 AM

bartek published this revision for review.Mar 8 2023, 10:43 AM

bartek added a reviewer: varun.Mar 9 2023, 2:42 AM

Accepting since a lot of the feedback was captured in the iOS diffs.

Just a quick inline question about iOS "compatibility" and changing condition from < to == and this should be good to land.

native/expo-modules/aes-crypto/android/src/main/java/app/comm/android/aescrypto/AESCryptoModule.kt
52–53 ↗	(On Diff #23542)	Should we be breaking this into three "pieces"? IV Ciphertext GCM tag
64–66 ↗	(On Diff #23542)	Mentioned this in the corresponding iOS diff, but I think it'd be good to use `==` to be more precise if we're assuming that they should always be exactly the same length.
74–75 ↗	(On Diff #23542)	Are these "bytes" going to be directly compatible with the `.combined` bytes from iOS? It seems like it's a standard format (`iv \|\| ciphertext \|\| tag`), but wasn't sure if there were any subtle differences or it's truly 1:1.