Page MenuHomePhabricator

[native] Move NotifPermissionAlertInfo to lib

Authored by michal on Fri, Mar 10, 7:28 AM.
Referenced Files
Unknown Object (File)
Sat, Mar 25, 10:03 AM
Unknown Object (File)
Tue, Mar 21, 10:21 AM
Unknown Object (File)
Mon, Mar 20, 2:20 PM
Unknown Object (File)
Thu, Mar 16, 3:35 PM
Unknown Object (File)
Mon, Mar 13, 11:36 AM
Unknown Object (File)
Mon, Mar 13, 11:36 AM
Unknown Object (File)
Mon, Mar 13, 7:26 AM



We want to show the notif permission modal on web less often and we can reuse NotifPermissionAlertInfo for this. This diff moves it from native redux to the shared redux setup and the base reducer. The next diff will actually use it on web.

Test Plan

Check if redux is correctly updated after showing the alerts on native. Test both a fresh device and when updating. The web was tested with the next diff, and it also correctly updates redux.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

Looks ok - it doesn't seem necessary to do a migration.

A test plan should include more checks:

  • does it work on web?
  • does it work on fresh native?
  • does it work when updating native?

I'm not sure but only 2nd or 3rd is covered by the current test plan.

This revision is now accepted and ready to land.Mon, Mar 13, 7:22 AM