Page MenuHomePhabricator
Differential D7046

[lib] Add test of ENS avatar set to NFT which is an SVG data URI
ClosedPublic
Actions

Authored by ashoat on Mar 11 2023, 4:26 PM.
Tags
None
Referenced Files
F1773058: D7046.diff
Wed, May 15, 9:16 PM
Unknown Object (File)
Tue, May 7, 8:44 PM
Unknown Object (File)
Tue, May 7, 8:44 PM
Unknown Object (File)
Thu, May 2, 2:39 AM
Unknown Object (File)
Apr 1 2024, 3:21 AM
Unknown Object (File)
Mar 31 2024, 1:19 PM
Unknown Object (File)
Mar 31 2024, 1:19 PM
Unknown Object (File)
Mar 31 2024, 1:17 PM
View All 60 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMdfc0d4818bb6: [lib] Add test of ENS avatar set to NFT which is an SVG data URI
Summary

This is a pretty complicated and ethers.js seems to handle it perfectly!

Note that I have some long lines here... with the data URI I don't think it really matters, and with the test declarations I figured they were more readable on one line. Can change either if preferred.

Depends on D7045

Test Plan
  1. Test plan described here, implemented via unit tests in this and preceding diffs
  2. Tested SVGs in React Native as noted here

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 11 2023, 4:26 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 11 2023, 4:26 PM
Harbormaster completed remote builds in B17260: Diff 23640.Mar 11 2023, 4:48 PM
ashoat requested review of this revision.Mar 11 2023, 4:48 PM
atul accepted this revision.Mar 11 2023, 9:20 PM

with the data URI I don't think it really matters

Personally think the cleanest approach would be to just move the data URI to its own file, but doesn't really matter

with the test declarations I figured they were more readable on one line

Agree

This revision is now accepted and ready to land.Mar 11 2023, 9:20 PM
ashoat added inline comments.Mar 12 2023, 12:04 PM
.eslintrc.json
22

I should update the comment too

Closed by commit rCOMMdfc0d4818bb6: [lib] Add test of ENS avatar set to NFT which is an SVG data URI (authored by ashoat). · Explain WhyMar 12 2023, 12:13 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMdfc0d4818bb6: [lib] Add test of ENS avatar set to NFT which is an SVG data URI.

Revision Contents
Changeset List

PathSize
2 lines
lib/
utils/
15 lines

Diff 23640

View Options

.eslintrc.json

Loading...
View Options

lib/utils/ens-cache.test.js

Loading...